Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md #38

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Update pull_request_template.md #38

merged 1 commit into from
Dec 18, 2023

Conversation

segdeha
Copy link
Member

@segdeha segdeha commented Dec 16, 2023

Update pull request template

Description

  • Removed table for the type of change :pour-one-out:
  • Added a couple of sentences guiding developers to use labels instead

Related Issue

Acceptance Criteria

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
💯 Add tests
🔗 Update dependencies
📜 Docs

Updates

Before

After

Testing Steps / QA Criteria

- Removed table for the type of change `:pour-one-out:`
- Added a couple of sentences guiding developers to use labels instead
@segdeha segdeha added the docs Work relating to the documentation of the project label Dec 16, 2023
Copy link
Contributor

@jeremiahfallin jeremiahfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good along with the new labels.

@segdeha segdeha merged commit 595c46e into main Dec 18, 2023
4 checks passed
@segdeha segdeha deleted the segdeha-pr-template branch December 18, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Work relating to the documentation of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants