Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete from all instances as lists' owner and unfollow shared lists #66

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

EmmaBin
Copy link
Collaborator

@EmmaBin EmmaBin commented Oct 13, 2024

Description

This PR resolves a bug where, when a list owner deletes a list, it would be removed from all instances, including for users it was shared with. For users who have the list shared with them, they can only unfollow the list—removing it from their sharedWithMe array—but not delete the original list. I also changed the delete icon to a remove icon for shared lists.

Related Issue

closes #60

Acceptance Criteria

  • When a user deletes a list that they have created and shared, the list is gone from all collections
  • When a user deletes a list that they have been shared to, but do not own, the list is removed from their collection, but not every collection that list belongs to. (I.e., the creator of a list is the only user who can permanently delete a list)

Type of Changes

bug fix enhancement

Updates

After

Screenshot 2024-10-12 at 4 52 10 PM

Screenshot 2024-10-12 at 4 52 29 PM
Screenshot 2024-10-12 at 4 53 00 PM

Testing Steps / QA Criteria

  1. go to eb-deletion-issue-32branch.
  2. Share some lists with other users and check the updates in Firebase under the 'sharedWithMe' lists.
  3. Delete the list shared with other users and confirm that it is removed from the 'sharedWithMe' lists.

Copy link

Visit the preview URL for this PR (updated for commit 999f350):

https://tcl-76-smart-shopping-list--pr66-eb-deletion-issue-32-7l9fs9s3.web.app

(expires Sun, 20 Oct 2024 00:04:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 512b1a88be8ae05fd3e727b99332819df760271d

Copy link
Collaborator

@arandel1 arandel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Love the update to the icon!

@EmmaBin EmmaBin merged commit a7abaf0 into main Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants