Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node version detail in readme #170

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Add node version detail in readme #170

merged 1 commit into from
Feb 15, 2024

Conversation

puranban
Copy link
Contributor

Changes

  • Add node version requirement in readme

This PR ensures that there are

  • No unnecessary console logs
  • No unwanted comments
  • No typos
  • yarn typecheck shows no issue
  • yarn lint shows no issue

This PR adds one or more new components / utils

  • Add the newly created component and its props to exports
  • Write story for newly created component(s)
  • No empty files

This PR fixes or updates existing components / utils

  • Update / add story to reflect the changes
  • Doesn't introduce breaking changes

Beta release vXX.XX.XX-beta.YY

  • Add a commit for beta release

@AdityaKhatri AdityaKhatri merged commit 4734b06 into develop Feb 15, 2024
5 of 6 checks passed
@AdityaKhatri AdityaKhatri deleted the fix/readme-node-version branch February 15, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaKhatri AdityaKhatri Awaiting requested review from AdityaKhatri

Assignees

@AdityaKhatri AdityaKhatri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puranban @AdityaKhatri