Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Round 1 #10

Open
IronRunes opened this issue Oct 16, 2017 · 1 comment
Open

Testing Round 1 #10

IronRunes opened this issue Oct 16, 2017 · 1 comment

Comments

@IronRunes
Copy link
Contributor

No description provided.

@thomwithoutanh
Copy link
Collaborator

thomwithoutanh commented Oct 19, 2017

generally, it's lovely! :)

  • Increase space between horizontal line and text on 'prove it', 'so what' and 'see all content' text
    image

  • Fix issue when messages are expanded they expand into the footer. This also happens with 'show all content'
    image

  • When you expand all 'prove it' and 'so what' boxes, it works up until message 4, when it's not possible to expand the text there or in message 5.

  • Resize Engine Room and MAVC logos so that they are aligned
    image

  • Increase size of funder logos and ensure that they are of a similar size
    image

  • Add creative commons logo in the footer (now added in the logos folder)

  • Fix issue where text expands into footer when you click 'see all content':

image

  • Fix display on mobile where sections are displaying on top of each other.
    image

  • To highlight that "Prove it" and "So what" are clickable, it'd be great if the :hover colour could be #007FFF

  • Could we lower the lines under "Prove it" and "OK, so what" a little bit (maybe 2 or 3px) - they're a bit too close:
    image

  • Low-priority: is there any more visual thing that we can add to the 'read the research' link? An icon like this perhaps? https://thenounproject.com/search/?q=document&i=1212327 Although if it wouldn't work, feel free to let me know.

  • Low priority thought: a part of me wanted to contract the 'prove it' and 'so what' boxes after reading them. Not 100% sure it's needed, but if it's easy to do, worth a go?


Things that Paola and I can do easily

  • remove line breaks between text and 'read full research'
    image

  • Create tweet-links for all 5 messages and 'tweet this site'

  • Correct typo in footer - from 'Making All Voice Count is implemented by' to 'Making All Voices Count is...'

  • Correct typo in footer - from 'Making All Voice Count is funded by' to 'Making All Voices Count is...'

  • In footer, change link from 'http://www.makingallvoicescount.org' to 'http://www.makingallvoicescount.org/publication/ and link text to 'read all Making All Voices Count's research'

  • Bold first line of 'prove it'

  • Add alt text to all 'Read the research' links

  • We need to remove a couple of pieces of research that are currently unpublished (pieterse and de Lanerolle). Paola and I will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants