Skip to content

Commit 7f382f4

Browse files
committed
CMake: fix a comment. [skip ci]
We're checking for both pcap_open() and pcap_findalldevs_ex(). (cherry picked from commit ae83a79)
1 parent 06b34f6 commit 7f382f4

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

CMakeLists.txt

+6-5
Original file line numberDiff line numberDiff line change
@@ -807,7 +807,8 @@ check_function_exists(pcap_dump_ftell64 HAVE_PCAP_DUMP_FTELL64)
807807
# to use when linking.)
808808
#
809809
# This means that check_function_exists() will think that
810-
# the remote-capture APIs are present, including pcap_open().
810+
# the remote-capture APIs are present, including pcap_open()
811+
# and pcap_findalldevs_ex().
811812
#
812813
# However, they are *not* present in macOS Ventura and earlier,
813814
# which means that building on Ventura with Xcode 15 produces
@@ -827,14 +828,14 @@ check_function_exists(pcap_dump_ftell64 HAVE_PCAP_DUMP_FTELL64)
827828
# Given all that, and given that the versions of the
828829
# remote-capture APIs in Sonoma are stubs that always fail,
829830
# there doesn't seem to be any point in checking for pcap_open()
830-
# if we're linking against the Apple libpcap.
831+
# and pcap_findalldevs_ex() if we're linking against the Apple libpcap.
831832
#
832833
# However, if we're *not* linking against the Apple libpcap,
833834
# we should check for it, so that we can use it if it's present.
834835
#
835-
# So we check for pcap_open if 1) this isn't macOS or 2) the
836-
# the libpcap we found is not a system library, meaning that
837-
# its path begins neither with /usr/lib (meaning it's a system
836+
# So we check for pcap_open() and pcap_findalldevs_ex() if 1) this isn't
837+
# macOS or 2) the the libpcap we found is not a system library, meaning
838+
# that its path begins neither with /usr/lib (meaning it's a system
838839
# dylib) nor /Application/Xcode.app (meaning it's a file in
839840
# the Xcode SDK).
840841
#

0 commit comments

Comments
 (0)