From 6b6bf2fb9180bb22dc593933864081c969a8105e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felipe=20Corr=C3=AAa=20da=20Silva=20Sanches?= Date: Fri, 1 Mar 2024 02:51:38 -0300 Subject: [PATCH] Disable legacy accents check. This is one of the checks that we probably should run on the sources instead of binaries. com.google.fonts/check/legacy_accents On the Universal profile. (https://github.com/fonttools/fontbakery/issues/3959#issuecomment-1822913547) --- CHANGELOG.md | 3 +++ Lib/fontbakery/checks/universal/__init__.py | 1 + Lib/fontbakery/profiles/universal.py | 2 +- tests/checks/universal_test.py | 2 +- 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 08ca70a4d1..a5c401d733 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,9 @@ A more detailed list of changes is available in the corresponding milestones for - v0.12.0a2 (2024-Feb-21) ### Changes to existing checks +#### On the Universal profile + - **DISABLED - [com.google.fonts/check/legacy_accents]:** This is one of the checks that we probably should run on the sources instead of binaries. (https://github.com/fonttools/fontbakery/issues/3959#issuecomment-1822913547) + #### On the Open Type Profile - **[com.google.fonts/check/layout_valid_feature_tags]:** Updated the check to allow valid private-use feature tags. (issue #4544) - **[com.google.fonts/check/varfont/family_axis_ranges]:** Updated the check to skip fonts without fvar tables. (issue #4554) diff --git a/Lib/fontbakery/checks/universal/__init__.py b/Lib/fontbakery/checks/universal/__init__.py index 9d63bbca7f..155ee05da6 100644 --- a/Lib/fontbakery/checks/universal/__init__.py +++ b/Lib/fontbakery/checks/universal/__init__.py @@ -741,6 +741,7 @@ def com_google_fonts_check_whitespace_ink(ttFont): yield PASS, "There is no whitespace glyph with ink." +@disable # https://github.com/fonttools/fontbakery/issues/3959#issuecomment-1822913547 @check( id="com.google.fonts/check/legacy_accents", proposal=[ diff --git a/Lib/fontbakery/profiles/universal.py b/Lib/fontbakery/profiles/universal.py index a514f520dc..2beed29b52 100644 --- a/Lib/fontbakery/profiles/universal.py +++ b/Lib/fontbakery/profiles/universal.py @@ -16,7 +16,7 @@ "com.google.fonts/check/whitespace_glyphs", "com.google.fonts/check/whitespace_glyphnames", "com.google.fonts/check/whitespace_ink", - "com.google.fonts/check/legacy_accents", + # "com.google.fonts/check/legacy_accents", # Disabled: issue #3595 / PR #4567 "com.google.fonts/check/required_tables", "com.google.fonts/check/unwanted_tables", "com.google.fonts/check/valid_glyphnames", diff --git a/tests/checks/universal_test.py b/tests/checks/universal_test.py index 608ee5c074..2d7d6a14d5 100644 --- a/tests/checks/universal_test.py +++ b/tests/checks/universal_test.py @@ -595,7 +595,7 @@ def test_check_whitespace_ink(): ) -def test_check_legacy_accents(): +def DISABLED_test_check_legacy_accents(): """Check that legacy accents aren't used in composite glyphs.""" check = CheckTester("com.google.fonts/check/legacy_accents")