From cacaa34517dd5d414c7be960019304a948457bc0 Mon Sep 17 00:00:00 2001 From: Bram Stein Date: Thu, 31 Aug 2023 14:47:11 +0200 Subject: [PATCH] Downgrade PANOSE consistency checks to WARN instead of FAIL (issue #4192) --- CHANGELOG.md | 2 ++ Lib/fontbakery/profiles/os2.py | 4 ++-- tests/profiles/os2_test.py | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8a30f8960f..94ff707591 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,6 +31,8 @@ A more detailed list of changes is available in the corresponding milestones for - **[com.google.fonts/check/grade_reflow]**: This check has been renamed to **com.google.fonts/check/varfont/duplexed_axis_reflow** and now also checks the `ROND` axis. (issue #4200) - **[com.google.fonts/check/glyph_coverage]:** This check is now skipped for icon fonts. (issues #3323 and #3327) +#### On the OpenType profile + - **[com.google.fonts/check/family/panose_familytype], [com.google.fonts/check/family/panose_proportion]:** Failures have been downgraded to warnings. (issue #4192) ## 0.9.0a2 (2023-Aug-04) ### Changes to existing checks diff --git a/Lib/fontbakery/profiles/os2.py b/Lib/fontbakery/profiles/os2.py index 0e02a3dc65..2f54407b44 100644 --- a/Lib/fontbakery/profiles/os2.py +++ b/Lib/fontbakery/profiles/os2.py @@ -35,7 +35,7 @@ def com_google_fonts_check_family_panose_proportion(ttFonts): ) if not passed: - yield FAIL, Message( + yield WARN, Message( "inconsistency", "PANOSE proportion is not the same across this family." " In order to fix this, please make sure that" @@ -71,7 +71,7 @@ def com_google_fonts_check_family_panose_familytype(ttFonts): ) if not passed: - yield FAIL, Message( + yield WARN, Message( "inconsistency", "PANOSE family type is not the same across this family." " In order to fix this, please make sure that" diff --git a/tests/profiles/os2_test.py b/tests/profiles/os2_test.py index bab788ac15..6f99737bb6 100644 --- a/tests/profiles/os2_test.py +++ b/tests/profiles/os2_test.py @@ -60,7 +60,7 @@ def test_check_family_panose_proportion(mada_ttFonts): mada_ttFonts[0]["OS/2"].panose.bProportion = incorrect_value assert_results_contain( - check(mada_ttFonts), FAIL, "inconsistency", "with inconsistent family." + check(mada_ttFonts), WARN, "inconsistency", "with inconsistent family." ) @@ -78,7 +78,7 @@ def test_check_family_panose_familytype(mada_ttFonts): mada_ttFonts[0]["OS/2"].panose.bFamilyType = incorrect_value assert_results_contain( - check(mada_ttFonts), FAIL, "inconsistency", "with inconsistent family." + check(mada_ttFonts), WARN, "inconsistency", "with inconsistent family." )