Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderToNodeStream example #17

Closed
sayjeyhi opened this issue Apr 1, 2020 · 4 comments
Closed

renderToNodeStream example #17

sayjeyhi opened this issue Apr 1, 2020 · 4 comments

Comments

@sayjeyhi
Copy link

sayjeyhi commented Apr 1, 2020

In Readme file you mentioned using of this Readable :

// small utility for "readable" streams
const readable = () => {
  const s = new Readable();
  s._read = () => true;
  return s;
};

But there is no usage for this variable , is it correct?

@theKashey
Copy link
Owner

You can find MUCH simpler examples in this PR #16

@theKashey
Copy link
Owner

yep, it should be readableString, used later in the code.

@sayjeyhi
Copy link
Author

sayjeyhi commented Apr 2, 2020

@theKashey actually in that example createStyleStream first parameter is htmlStream but even in 2.1.1 version createStyleStream first argument is style definition !

@theKashey
Copy link
Owner

It sounds like I should extract examples out of the README to keep them type-able, and synchronize their content back the readme, so it would be always up-to-date. Not like it is right now :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants