media query support

[hnrchrdl]

are media queries supposed to be supported by this library? I guess not properly, I do not seem to get any critical css for selectors that are behind media queries.

[theKashey]

Should work, there is even an issue about the cases when it should not - #10

However add I've added a few test to double check, and they are all green.

[hnrchrdl]

thanks a lot for looking into this. tests look good.
the problem is with filtering used selectors, at least when using criticalStylesToString.

for example considering the following css

h1 {
  margin-top: 50px;
}
h1 {
  @include breakpoint(small only) {
    margin-top: 30px;
  }
}

it would only interleave the first rule. the second one with the media query is filtered because the selector was already used.

[theKashey]

Not sure that's a valid CSS. It's more looks like SASS

[theKashey]

In short

• the tests I've added are working great
• there is another place there error is happening - the filter function

• used-styles/src/reporters/critical.ts

  Line 35 in 5c61ccb

  const filter = (selector: string) => {

[theKashey]

Should be fine from now on.