this is special only for header files

thebrowsercompany · Aug 16, 2023 · 11cf993 · 11cf993
1 parent d42fee1
commit 11cf993
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/swiftwinrt/abi_writer.h b/swiftwinrt/abi_writer.h
@@ -100,9 +100,15 @@ namespace swiftwinrt
     // Don't write "built-in types" since these are defined in other header files
     // These aren't completely removed from metadata because we need to generate them
     // on the swift side
+    static std::set<std::string_view> removed_types = {
+        "Windows.Foundation.Collections.CollectionChange",
+        "Windows.Foundation.Collections.IVectorChangedEventArgs",
+        "Windows.Foundation.IAsyncInfo",
+        "Windows.Foundation.AsyncStatus"
+    };     
     static bool should_write(metadata_type const& type)
     {
-        return !use_sdk_c_header_definition(type);
+        return !removed_types.contains(type.swift_full_name());
     }
 
     static void write_includes(writer& w, type_cache const& types, std::string_view fileName)

diff --git a/swiftwinrt/helpers.h b/swiftwinrt/helpers.h
@@ -907,15 +907,4 @@ namespace swiftwinrt
 
         return true;
     }
-
-    inline bool use_sdk_c_header_definition(metadata_type const& type)
-    {
-        static std::set<std::string_view> removed_types = {
-            "Windows.Foundation.Collections.CollectionChange",
-            "Windows.Foundation.Collections.IVectorChangedEventArgs",
-            "Windows.Foundation.IAsyncInfo",
-            "Windows.Foundation.AsyncStatus"
-        };        
-        return removed_types.contains(type.swift_full_name());
-    }
 }