withSymlinks({ resolvePaths: false }) hang when crawling /

[SuperchupuDev]

works when resolving paths. repro code (only tested on linux):

import { fdir } from 'fdir';

const files = await new fdir()
  .exclude((_, f) => {
    // doing this to avoid crawling anything recursively
    console.log('ignoring', f);
    return true;
  })
  .withSymlinks({ resolvePaths: false })
  .crawl('/')
  .withPromise();

console.log(files);

it looks like isRecursive from resolve-symlinks.ts gets called with the following arguments and enters an infinite loop:

'/lib', '/usr/lib', {
  root: '',
  paths: [],
  groups: [],
  counts: Counter { _files: 0, _directories: 1 },
  options: {
    maxDepth: Infinity,
    suppressErrors: true,
    pathSeparator: '/',
    filters: [],
    exclude: [Function (anonymous)],
    resolveSymlinks: true,
    useRealPaths: false,
    resolvePaths: true,
    includeBasePath: true
  },
  queue: Queue { onQueueEmpty: [Function (anonymous)], count: 4 },
  symlinks: Map(0) {},
  visited: [ '/' ]
}

the while loop of the function seems to always run with the variables parent = "/", state.root = "", depth = 1. state.root doesn't look like it's properly computed?

[pralkarz]

The incorrect state.root seems to stem from the change introduced in a492652. Changing it to this.root === "/" ? this.root : this.root.slice(0, -1) fixes the issue, but I don't know what the implications could be. 😄