Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hammer-cli-foreman-rh-cloud package #1145

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Add hammer-cli-foreman-rh-cloud package #1145

merged 1 commit into from
Nov 23, 2023

Conversation

ShimShtein
Copy link
Member

No description provided.

@ShimShtein ShimShtein force-pushed the hammer-cli-foreman-rh-cloud branch from 7abb94c to b086d7a Compare November 22, 2023 10:16
ekohl
ekohl requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it to https://github.com/theforeman/puppet-foreman/blob/master/spec/classes/cli_plugins_spec.rb & https://github.com/theforeman/puppet-foreman/blob/master/spec/acceptance/foreman_cli_plugins_spec.rb so it gets tested.

@ShimShtein ShimShtein force-pushed the hammer-cli-foreman-rh-cloud branch from b086d7a to a013876 Compare November 22, 2023 13:17
@ShimShtein ShimShtein force-pushed the hammer-cli-foreman-rh-cloud branch from a013876 to 85ee868 Compare November 22, 2023 13:54
@ShimShtein ShimShtein force-pushed the hammer-cli-foreman-rh-cloud branch from 85ee868 to 2a526a1 Compare November 23, 2023 08:46
@ShimShtein
Copy link
Member Author

@ekohl Refactored the acceptance tests to incorporate the plugin the same way Katello does.
The tests are all green now!

ekohl
ekohl approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! https://github.com/theforeman/foreman-plugin-overview/blob/014863c694f1d1642ed8751fa193a9c3a7a1b04a/config.yaml#L394 also needs an update after this, though perhaps only after we add it to foreman-installer.

@ekohl ekohl merged commit b310618 into theforeman:master Nov 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShimShtein @ekohl