Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreman 3.10.0 rc2 #355

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Foreman 3.10.0 rc2 #355

merged 1 commit into from
Mar 5, 2024

Conversation

pcreech
Copy link
Member

@pcreech pcreech commented Mar 5, 2024

No description provided.

@@ -1 +1,2 @@
OSES="el7 el8 el9"
FULLVERSION='3.10.0-rc2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client doesn't need that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'twas an artifact of branching, removing

@@ -1 +1 @@
OSES="el7 el8 el9"
OSES='el7 el8 el9'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic, but why the quote change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because locally i had ''' instead of '"', noticed just now as well, fixing, as technically it should be unmodified with the removal of the foreman version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now to only change 1 file.

@pcreech pcreech merged commit ca9a9df into theforeman:master Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants