Skip to content

Commit

Permalink
Fix remaining IRC leftovers in this repo
Browse files Browse the repository at this point in the history
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
  • Loading branch information
ares and ekohl authored Sep 23, 2024
1 parent 6d7baac commit 0159fb8
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion contribute.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ title: Contributing to Foreman

The Foreman is an open-source project that's licensed under the GNU General Public License version 3. Contributions of all types are gladly accepted! Before setting up your development environment, check out our [issue tracker](https://projects.theforeman.org/projects). We have a list of [trivial or easy](https://projects.theforeman.org/projects/foreman/issues?query_id=42) issues in the Foreman core project. Similar queries can be done in other projects on the issue tracker.

Before writing any code, read the Foreman [handbook](/handbook.html) for some code guidelines and recommendations. You can find us on both our forum and IRC if you run into trouble when selecting issues or setting up your development environment. See our [Support](/support) page for all the details on how to come chat with us.
Before writing any code, read the Foreman [handbook](/handbook.html) for some code guidelines and recommendations. You can find us on both our forum and Matrix.org if you run into trouble when selecting issues or setting up your development environment. See our [Support](/support) page for all the details on how to come chat with us.

### Setting up a development environment

Expand Down
4 changes: 2 additions & 2 deletions handbook.md
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ Write a good description, a good title, and explain why the change is necessary.

Assume reviewers have no idea or background about your patch. Even if the usual reviewers know you personally and you know they know why your change is necessary, maybe not all reviewers are aware of it. Furthermore, after some time, they might not remember well, and new reviewers will not be able to review your code without background and a good explanation.

Generally, if you want to submit significant changes to the code, discuss it first on #theforeman-dev (libera.chat) or the Development board on our [forum](https://community.theforeman.org/c/development). If you know who are the usual maintainers for the code you want to change, try to ask them to validate your assumptions, your design, and if they can, ask them to review your code. This will save you a lot of going back and forth with reviewers that do not understand the reasoning behind your pull request.
Generally, if you want to submit significant changes to the code, discuss it first on #theforeman-dev:matrix.org (Matrix) or the Development board on our [forum](https://community.theforeman.org/c/development). If you know who are the usual maintainers for the code you want to change, try to ask them to validate your assumptions, your design, and if they can, ask them to review your code. This will save you a lot of going back and forth with reviewers that do not understand the reasoning behind your pull request.

Submit changes incrementally. If you are submitting a pull request that will break compatibility with older APIs, spend the effort to make it compatible first. If you think your feature is not ready for prime time yet, it's OK to submit small changes and hide the feature using feature flags.

Expand Down Expand Up @@ -318,7 +318,7 @@ If you want to become a committer, we expect you help with some of these tasks:

Other things that are nice to do:

* Support users and other developers on the [forum](https://community.theforeman.org/), in Redmine, and in IRC #theforeman and #theforeman-dev
* Support users and other developers on the [forum](https://community.theforeman.org/), in Redmine, and in Matrix #theforeman:matrix.org and #theforeman-dev:matrix.org
* Participate in (or even initiate) real-world events such as user/developer meetups, papers/talks at conferences, etc

#### How do I become a committer?
Expand Down
6 changes: 3 additions & 3 deletions mentoring.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ currently available projects.
* Skim through the [manual](/manuals/latest/index.html)
* Watch a few [demo videos](/media.html)
* Read a couple posts from the [forum](/support.html#forum)
* Join us on [IRC](/support.html#IRC):
* \#theforeman on libera.chat for generally getting to know Foreman and asking user questions
* \#theforeman-dev on libera.chat for development/mentoring questions. Don't be shy; tell us you're interested in one of our open mentoring projects
* Join us on [Matrix.org](/support.html#Matrix.orglivechat):
* \#theforeman for generally getting to know Foreman and asking user questions
* \#theforeman-dev for development/mentoring questions. Don't be shy; tell us you're interested in one of our open mentoring projects

## Open Projects

Expand Down
10 changes: 5 additions & 5 deletions privacy.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ number of open/closed bugs, average time to close a bug, etc.

## Communication

The Foreman project maintains two public IRC channels on
[libera.chat](https://libera.chat), refer to [libera.chat's privacy
policy](https://libera.chat/privacy) for details on how they handle your data.
The Foreman project maintains two public Matrix rooms on
[matrix.org](https://matrix.org), refer to [Matrix.org's privacy
policy](https://matrix.org/_matrix/consent) for details on how they handle your data.

The Foreman community uses a self-hosted forum using the
[Discourse](https://discourse.org) software. When signing up for a Discourse
Expand Down Expand Up @@ -195,7 +195,7 @@ rights, subject to some limitations, against the Foreman Project:

If you would like to exercise any of these rights, you may do so by contacting
the Foreman Project at [contact us](mailto:[email protected])
or on [IRC](/support.html#IRClivechat). Please understand, however, the rights
or on [Matrix](/support.html#Matrix.orglivechat). Please understand, however, the rights
enumerated above are not absolute in all cases, especially in regards to the
right to erase your data:

Expand All @@ -211,7 +211,7 @@ right to erase your data:

If you have any questions about this policy or our use of your data, please
feel free to [contact us](mailto:[email protected]) or on
[IRC](/support.html#IRClivechat).
[Matrix](/support.html#Matrix.orglivechat).

# Changes to this Privacy Statement

Expand Down

0 comments on commit 0159fb8

Please sign in to comment.