Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update superset version #142

Merged
merged 6 commits into from
Oct 21, 2022
Merged

Conversation

esloch
Copy link
Contributor

@esloch esloch commented Oct 11, 2022

Resolve #140.

@esloch esloch requested a review from xmnlab October 11, 2022 15:47
@xmnlab xmnlab marked this pull request as ready for review October 11, 2022 15:52
@xmnlab
Copy link
Member

xmnlab commented Oct 11, 2022

LGTM! let's wait for the CI before merging this PR! thanks for working on that @esloch !

@xmnlab
Copy link
Member

xmnlab commented Oct 15, 2022

I think we should have a specific conda environment file for superset and another one for airflow.

the superset file should contain just the dependencies for superset.

the airflow file should include the epigraphhub(_py) dependency and maybe the other dependencies as defined by prod.yaml.

not sure now about the R dependencies, because right now we don't have any R code running on the airflow container.

@fccoelho we need to discuss again about the R package. Also, maybe we could discuss again the multi api approach: https://github.com/thegraphnetwork/epigraphhub-enhancement-proposals/pull/1/files#diff-6239aab7993539c8ff8b64897e61817500667bc35e547d8be4365f311faac79d (of course, it is not something for this PR)

@xmnlab xmnlab merged commit 76e81b5 into thegraphnetwork:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use EpiGraphHub nightly from opensciencelabs conda channel
2 participants