Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR: models\model-settings.php #40

Open
ghost opened this issue Apr 27, 2016 · 0 comments
Open

CR: models\model-settings.php #40

ghost opened this issue Apr 27, 2016 · 0 comments

Comments

@ghost
Copy link

ghost commented Apr 27, 2016

Code Review: models\model-settings.php

  • Lines 24-25
    It's better to use <sup> tag for these values
  • Line 29
    Constants must be defined at the top of the class.
  • Line 43
    The function should be removed as it's only function is to wrap the native one. Use the native function without any wrappers.
  • Lines 52-54
    Use is_created() method here. Method requires refactoring.
  • Line 84, Line 93,
    Line 112,
    Line 121

    These functions should be removed as their only function is to wrap the native one. Use the native function without any wrappers.
  • Lines 131-132
    To many spaces/tabs before the = (equal) sign, single space expected.
  • Line 144, Line 158
    Methods are the same, single method should be used instead.
  • Lines 145-146, Lines 198-199, Line 218, Lines 229-230, Lines 245-248, Lines 256-259, Lines 267-270, Lines 277-281, Lines 289-292
    Use single space before & after the = sign.
  • Line 209
    Check if array key exists before returning the value.
  • Line 226
    DRY: do not repeat yourself. This method requires refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants