-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TheiaProk wfs] upgrade StxTyper version when available & ensure all OPERON output types are captured appropriately #694
Comments
The stxtyper v1.0.27 docker image is available from staphb: https://github.com/StaPH-B/docker-builds/tree/master/build-files/stxtyper/1.0.27 the docker image should be copied over to our google artifact registry and the stxtyper WDL task should be updated to use the image as default |
Perhaps hold off on this update. It looks like a new stxtyper version is incoming. https://github.com/ncbi/stxtyper/tree/dev Let's wait until that is released and a new docker image can be created via StaPH-B |
New version is available. I can make a staphb docker image |
OK docker image has been copied to our GAR This issue is ready to be worked on |
1.0.40 is the latest version, the docker image is on our GAR: there is an incoming 1.0.41 version, but it hasn't been released yet. I don't think it's necessary to upgrade unless the timing is right and the docker image for 1.0.41 is available |
🆒
📌 Explain the Request
request 1 - upgrade version
This is an internal request from me, but would be desired by our public health partners (CA) and users. It is a low priority request at the moment but may be upgraded priority pending on feedback from CA partners
Version of StxTyper in theiaprok workflows currently: 1.0.24
Current version available on NCBI StxTyper GitHub: 1.0.27
FYI in the coming months there will be a new version released with minor bug fixes for edge cases. I will reply back when it's available.StaPH-B/Curtis will make a docker image available for the new version when it is released.We can copy this to our google artifact registry once available.request 2 - update parsing of results; potentially add new string output to task and workflows
I want to also use this opportunity to ensure that the stxtyper task in theiaprok accurately captures all potential OPERON types.
I accidentally omitted searching for hits with
EXTENDED
andAMBIGUOUS
operon type so that is not very visible to the user unless they look in the stxtyper_report TSV file (raw output from the tool). They are rarely found, but still would be good to capture and notify the end user of the TheiaProk workflow in case they are found by stxtyper.From StxTyper README description:
and
The text was updated successfully, but these errors were encountered: