Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK4 support #75

Open
JohnOberhauser opened this issue Apr 19, 2021 · 13 comments
Open

GTK4 support #75

JohnOberhauser opened this issue Apr 19, 2021 · 13 comments

Comments

@JohnOberhauser
Copy link

Arch is using gnome 40 with gtk4 support now. It would be awesome if the oomox theme supported gtk4.

@actionless
Copy link
Member

actionless commented Apr 26, 2021

"it would be awesome" if somebody would send such a PR for sure:

from my own perspective is too raw and buggy right now to touch it -- for example on one of my machines on latest gtk4 version, gtk-widget-factory still keep crashing (probably due to vdpau handling bugs)

and til the time gtk4 will became stable -- they prolly change theming api few times, as they usually did in every gtk3 release til 3.20

so before investing any time into i first gonna wait when it will be both functionally- and api-stable enough

if you have a different opinion on this, you're free to invest into implementing it yourself, and share the results.

however, considering what not too many apps already moved to gtk4, you can just use Materia theme generated from the same Themix color palette, to visually match the environment

@actionless actionless transferred this issue from themix-project/themix-gui Apr 26, 2021
@JohnOberhauser
Copy link
Author

yeah, I ended up using hacking materia to look similar-ish to oomox/numix. It ended up looking pretty good

@actionless
Copy link
Member

not good enough for sharing the result though?

@actionless
Copy link
Member

actionless commented Feb 28, 2022

considering all weird things happening with GTK4 (i refer to recent libadwaita controversy):

i personally dont see much point investing time into it until theming api will became 1) documented; and 2) "changelog-able"

but as i mentioned before, PRs still will be accepted

@yavko
Copy link

yavko commented Apr 5, 2022

There is a pretty easy way to theme libadwaita apps, though IMO supporting gtk4 for non libadwaita apps or other things would be great. I think there is more documentation on it though I'm not sure.

@actionless
Copy link
Member

@yavko can't wait for that cool PR from you based on their robust documentation :D

@yavko
Copy link

yavko commented Apr 5, 2022

@yavko can't wait for that cool PR from you based on their robust documentation :D

Even though I don't use oomox-gtk, but I'll do it! But idk how long it'll take 💀, so no guarantees

@actionless
Copy link
Member

actionless commented Apr 5, 2022

btw i actually tested latest versions of oomox-gtk3-theme and gtk4-widget-factory and it's aparently not so much fixes to do visually (at least from the first glance, mb in other places it all worse), but there are lots of theme parsing errors, due to some changes in gtk not clearly described in CHANGELOG.txt

and because(?) of these theme-parsing errors choosing the theme makes any application unusably slow, like 10FPS-ish

gtk3:
2022-04-05--1649152847_1920x1080_scrot

gtk4:
2022-04-05--1649152883_1920x1080_scrot

@actionless
Copy link
Member

another option is to switch to libadwaita's css for gtk4, because by structure it's similar to materia but doesnt have any image assets to render - it's quite easy to use in Themix and visual changes from Oomox theme are notable but not really crucial:

2022-06-02--1654198213_1688x969_scrot

@yavko
Copy link

yavko commented Jun 2, 2022

I finally have time to try porting it myself, though as I said before I can't guarantee I will finish it at all lol

@niksingh710
Copy link

wpgtk issue
Here in this issue wpgtk dev created a theme linea that works with gtk4.
maybe that helps here to get gtk4 support

@actionless
Copy link
Member

@niksingh710 the problem is not "how to create any gtk4 theme" (https://github.com/themix-project/themix-plugin-base16/tree/master/templates_extra/gtk4/templates), the problem that no one is in sane mind to spend their own time to rewrite existing oomox theme to randomly changed (and what's more important always changING) gtk theming api created by distalented gnome team, whos bigger project goal is wasting as much ibm money as possible without delivering anything useful. (because otherwise the gnome project will be finished and they will be sent doing some boring servering software)

@actionless
Copy link
Member

however, since wpgtk theme support both gtk3 and gtk4 with the same style - feel free adding themix plugin for that theme: https://github.com/themix-project/themix-gui/tree/master/plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants