Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates for tasks should be done only by extending transcription template. #105

Open
6 of 7 tasks
KrzysztofMadejski opened this issue Jan 8, 2018 · 2 comments
Open
6 of 7 tasks

Comments

@KrzysztofMadejski
Copy link
Member

KrzysztofMadejski commented Jan 8, 2018

  • Delete task.html. We will have a sample one in project_template.
  • Delete reference to it here
  • Rewrite the mechanism of overriding templates and forms in tasks in views.py
    • rename the method from _get_form_class_data to something better. post_initialize?
    • delete those TODOs there
    • rename task_template to just template in if hasattr(self.task, 'task_template'):
    • delete from the function and from the implementing tasks the self.form_template_name = getattr(self.task, 'task_form_template', None)
  • rename exception:
    if not self.template:
              raise TaskMustSetTemplate(self.task.__class__) # instead of TaskWithNoTemplateNorForm
    
  • Adjust Opora to above changes
  • Rewrite KMonitor to extend rather than include
  • Update documentation
@ppeczek
Copy link
Contributor

ppeczek commented Jan 10, 2018

@KrzysztofMadejski, please check if everything's fine. Projects: OPORA and KMonitor have been updated.

@KrzysztofMadejski
Copy link
Member Author

@ppeczek I don't see code updated in KMonitor repo.

I've checked documentation and added {% extends "transcription.html" %} there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants