Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more ProjectTypes and minor adjustments #43

Merged
merged 2 commits into from
Sep 29, 2023
Merged

fix: more ProjectTypes and minor adjustments #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c393fb
fixes
jessicamcinchak Sep 29, 2023
10c07f4
make submittedAt optional while testing
jessicamcinchak Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/data/Applicant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export const validApplicant: Schema['data']['applicant'] = {
interest: 'owner.co',
ownership: {
certificate: 'a',
noticeGiven: true,
owners: [
{
name: 'Owner 1',
Expand All @@ -29,13 +30,11 @@ export const validApplicant: Schema['data']['applicant'] = {
town: 'Anywhere',
postcode: 'SE5 0HU',
},
noticeGiven: true,
noticeDate: '2023-10-01',
},
{
name: 'Owner 2',
address: 'Same as Owner 1',
noticeGiven: false,
},
],
},
Expand Down
4 changes: 3 additions & 1 deletion examples/data/Application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ export const validApplication: Schema['data']['application'] = {
},
declaration: {
accurate: true,
connection: 'none',
connection: {
value: 'none',
},
},
};
6 changes: 5 additions & 1 deletion examples/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import {validResponses} from './data/Responses';

const validMetadata: Schema['metadata'] = {
service: {
publishedFlowId: 'b3320abe-f5bc-4185-b61f-40e9e65f07ad',
flowId: 'b3320abe-f5bc-4185-b61f-40e9e65f07ad',
publishedFlowId: 22,
name: 'Test',
owner: 'Test',
url: 'https://www.planx.uk/',
Expand All @@ -18,6 +19,9 @@ const validMetadata: Schema['metadata'] = {
createdAt: '2018-11-13T20:20:39+00:00',
submittedAt: '2018-11-13T20:20:39+00:00',
},
schema: {
url: 'https://theopensystemslab.github.io/digital-planning-data-schemas/v0.0.1/schema.json',
},
};

const validFiles: Schema['files'] = [
Expand Down
10 changes: 8 additions & 2 deletions examples/validExampleAgent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@
},
"declaration": {
"accurate": true,
"connection": "none"
"connection": {
"value": "none"
}
}
},
"property": {
Expand Down Expand Up @@ -222,7 +224,8 @@
],
"metadata": {
"service": {
"publishedFlowId": "b3320abe-f5bc-4185-b61f-40e9e65f07ad",
"flowId": "b3320abe-f5bc-4185-b61f-40e9e65f07ad",
"publishedFlowId": 22,
"name": "Test",
"owner": "Test",
"url": "https://www.planx.uk/"
Expand All @@ -232,6 +235,9 @@
"id": "b3320abe-f5bc-4185-b61f-40e9e65f07ad",
"createdAt": "2018-11-13T20:20:39+00:00",
"submittedAt": "2018-11-13T20:20:39+00:00"
},
"schema": {
"url": "https://theopensystemslab.github.io/digital-planning-data-schemas/v0.0.1/schema.json"
}
},
"responses": [
Expand Down
15 changes: 10 additions & 5 deletions examples/validExampleApplicant.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"interest": "owner.co",
"ownership": {
"certificate": "a",
"noticeGiven": true,
"owners": [
{
"name": "Owner 1",
Expand All @@ -32,13 +33,11 @@
"town": "Anywhere",
"postcode": "SE5 0HU"
},
"noticeGiven": true,
"noticeDate": "2023-10-01"
},
{
"name": "Owner 2",
"address": "Same as Owner 1",
"noticeGiven": false
"address": "Same as Owner 1"
}
]
}
Expand Down Expand Up @@ -66,7 +65,9 @@
},
"declaration": {
"accurate": true,
"connection": "none"
"connection": {
"value": "none"
}
}
},
"property": {
Expand Down Expand Up @@ -217,7 +218,8 @@
],
"metadata": {
"service": {
"publishedFlowId": "b3320abe-f5bc-4185-b61f-40e9e65f07ad",
"flowId": "b3320abe-f5bc-4185-b61f-40e9e65f07ad",
"publishedFlowId": 22,
"name": "Test",
"owner": "Test",
"url": "https://www.planx.uk/"
Expand All @@ -227,6 +229,9 @@
"id": "b3320abe-f5bc-4185-b61f-40e9e65f07ad",
"createdAt": "2018-11-13T20:20:39+00:00",
"submittedAt": "2018-11-13T20:20:39+00:00"
},
"schema": {
"url": "https://theopensystemslab.github.io/digital-planning-data-schemas/v0.0.1/schema.json"
}
},
"responses": [
Expand Down
Loading
Loading