Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update missing or incorrect enum values #58

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix: update missing or incorrect enum values #58

merged 2 commits into from
Oct 20, 2023

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Oct 20, 2023 •
edited
Loading

  • Adds other option to data.applicant.interest
  • Adds proposal.photograph.evidence to FileType
  • Updates property.site.locationPlan → property.drawing.locationPlan in FileType
  • Updates descriptions only for elevations & sections in FileType

Fixes validation errors thrown for a number of past applications checked here: theopensystemslab/planx-core#166

@jessicamcinchak jessicamcinchak mentioned this pull request Oct 20, 2023
Merged
DafyddLlyr
DafyddLlyr approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question - I might just be missing something here?

types/schema/data/Property.ts Outdated Show resolved Hide resolved
@jessicamcinchak jessicamcinchak merged commit 9bee7ec into main Oct 20, 2023
3 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/update-enums branch October 20, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicamcinchak @DafyddLlyr