Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data.property.planning type should use more precise language #64

Merged
merged 4 commits into from
Nov 9, 2023
Merged

fix: data.property.planning type should use more precise language #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5e9b07
property names should match geo query method
jessicamcinchak Nov 1, 2023
173eeb2
Merge branch 'main' of github.com:theopensystemslab/digital-planning-…
jessicamcinchak Nov 8, 2023
bb25ae4
Merge branch 'main' of github.com:theopensystemslab/digital-planning-…
jessicamcinchak Nov 8, 2023
02b341c
new planning constraint shape including source link
jessicamcinchak Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 43 additions & 40 deletions examples/data/ldcE.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,107 +151,110 @@ export const validLDCE: Schema = {
squareMetres: 2993.67,
},
},
constraints: {
planning: [
{
value: 'tpo',
description: 'Tree Preservation Order (TPO) or zone',
overlaps: false,
},
planning: {
source: 'https://api.editor.planx.dev/gis/buckinghamshire?geom=test',
designations: [
{
value: 'listed',
description: 'Listed Building',
overlaps: false,
},
{
value: 'article4',
description: 'Article 4 Direction area',
overlaps: true,
entities: [
{
name: 'Whole District excluding the Town of Chesham - Poultry production.',
description:
'Bucks County Council Town and Country Planning Act 1947 Town and Country Planning General Development Order 1950. Re Whole District excluding the Town of Chesham. In relation to poultry production.',
source: 'https://www.planning.data.gov.uk/entity/7010002192',
},
],
},
{
value: 'article4.caz',
description: 'Central Activities Zone (CAZ)',
overlaps: false,
intersects: false,
},
{
value: 'monument',
description: 'Site of a Scheduled Monument',
overlaps: false,
intersects: false,
},
{
value: 'designated',
description: 'Designated land',
overlaps: true,
intersects: true,
entities: [],
},
{
value: 'nature.SAC',
description: 'Special Area of Conservation (SAC)',
overlaps: false,
intersects: false,
},
{
value: 'nature.ASNW',
description: 'Ancient Semi-Natural Woodland (ASNW)',
overlaps: false,
intersects: false,
},
{
value: 'nature.SSSI',
description: 'Site of Special Scientific Interest (SSSI)',
overlaps: false,
intersects: false,
},
{
value: 'locallyListed',
description: 'Locally Listed Building',
overlaps: false,
intersects: false,
},
{
value: 'designated.SPA',
description: 'Special Protection Area (SPA)',
overlaps: false,
intersects: false,
},
{
value: 'designated.WHS',
description: 'UNESCO World Heritage Site or buffer zone',
overlaps: false,
intersects: false,
},
{
value: 'registeredPark',
description: 'Historic Park or Garden',
overlaps: false,
intersects: false,
},
{
value: 'designated.AONB',
description: 'Area of Outstanding Natural Beauty (AONB)',
overlaps: true,
intersects: true,
entities: [{name: 'Chilterns'}],
},
{
value: 'designated.nationalPark',
description: 'National Park',
overlaps: false,
intersects: false,
},
{
value: 'designated.conservationArea',
description: 'Conservation Area',
overlaps: false,
intersects: false,
},
{
value: 'designated.nationalPark.broads',
description: 'National Park - Broads',
overlaps: false,
intersects: false,
},
{
value: 'road.classified',
description: 'Classified Road',
overlaps: false,
intersects: false,
},
],
orders: [
{
value: 'article4',
description: 'Article 4 Direction area',
intersects: true,
entities: [
{
name: 'Whole District excluding the Town of Chesham - Poultry production.',
description:
'Bucks County Council Town and Country Planning Act 1947 Town and Country Planning General Development Order 1950. Re Whole District excluding the Town of Chesham. In relation to poultry production.',
source: 'https://www.planning.data.gov.uk/entity/7010002192',
},
],
},
{
value: 'article4.caz',
description: 'Central Activities Zone (CAZ)',
intersects: false,
},
{
value: 'tpo',
description: 'Tree Preservation Order (TPO) or zone',
intersects: false,
},
],
},
Expand Down
67 changes: 35 additions & 32 deletions examples/data/ldcP.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,97 +95,100 @@ export const validLDCP: Schema = {
squareMetres: 1418.26,
},
},
constraints: {
planning: [
{
value: 'tpo',
description: 'Tree Preservation Order (TPO) or zone',
overlaps: false,
},
planning: {
source: 'https://api.editor.planx.dev/gis/buckinghamshire?geom=test',
designations: [
{
value: 'listed',
description: 'Listed Building',
overlaps: false,
},
{
value: 'article4',
description: 'Article 4 Direction area',
overlaps: false,
intersects: false,
},
{
value: 'monument',
description: 'Site of a Scheduled Monument',
overlaps: false,
intersects: false,
},
{
value: 'designated',
description: 'Designated land',
overlaps: false,
intersects: false,
},
{
value: 'nature.SAC',
description: 'Special Area of Conservation (SAC)',
overlaps: false,
intersects: false,
},
{
value: 'nature.ASNW',
description: 'Ancient Semi-Natural Woodland (ASNW)',
overlaps: false,
intersects: false,
},
{
value: 'nature.SSSI',
description: 'Site of Special Scientific Interest (SSSI)',
overlaps: false,
intersects: false,
},
{
value: 'locallyListed',
description: 'Locally Listed Building',
overlaps: false,
intersects: false,
},
{
value: 'designated.SPA',
description: 'Special Protection Area (SPA)',
overlaps: false,
intersects: false,
},
{
value: 'designated.WHS',
description: 'UNESCO World Heritage Site or buffer zone',
overlaps: false,
intersects: false,
},
{
value: 'registeredPark',
description: 'Historic Park or Garden',
overlaps: false,
intersects: false,
},
{
value: 'designated.AONB',
description: 'Area of Outstanding Natural Beauty (AONB)',
overlaps: false,
intersects: false,
},
{
value: 'designated.nationalPark',
description: 'National Park',
overlaps: false,
intersects: false,
},
{
value: 'designated.conservationArea',
description: 'Conservation Area',
overlaps: false,
},
{
value: 'article4.caz',
description: 'Central Activities Zone (CAZ)',
overlaps: false,
intersects: false,
},
{
value: 'designated.nationalPark.broads',
description: 'National Park - Broads',
overlaps: false,
intersects: false,
},
{
value: 'road.classified',
description: 'Classified Road',
overlaps: false,
intersects: false,
},
],
orders: [
{
value: 'article4',
description: 'Article 4 Direction area',
intersects: false,
},
{
value: 'article4.caz',
description: 'Central Activities Zone (CAZ)',
intersects: false,
},
{
value: 'tpo',
description: 'Tree Preservation Order (TPO) or zone',
intersects: false,
},
],
},
Expand Down
Loading
Loading