feat: Rename gdhi, add not null constraints (#163)

* feat: Rename gdhi tables, add not null constraints * test: Update test case
theopensystemslab · Dec 13, 2024 · 6321c94 · 6321c94
1 parent 6312e95
commit 6321c94
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/app/data/gdhiRepo.test.ts b/app/data/gdhiRepo.test.ts
@@ -31,7 +31,6 @@ describe("gdhiRepo", () => {
       where: {
         AND: {
           itl3: { equals: itl3 },
-          gdhi2020: { not: null },
         },
       },
       select: { gdhi2020: true },

diff --git a/app/data/gdhiRepo.ts b/app/data/gdhiRepo.ts
@@ -6,14 +6,12 @@ const getGDHI2020ByITL3 = async (itl3: string): Promise<number> => {
       where: {
         AND: {
           itl3: { equals: itl3 },
-          // TODO: Add `NOT NULL` constraint to column
-          gdhi2020: { not: null },
         },
       },
       select: { gdhi2020: true },
     });
 
-    return gdhi2020 as number;
+    return gdhi2020;
   } catch (error) {
     throw Error(`Data error: Unable to find gdhi2020 for itl3 ${itl3}`);
   }

diff --git a/prisma/migrations/20241206162843_rename_ghdi_table/migration.sql b/prisma/migrations/20241206162843_rename_ghdi_table/migration.sql
@@ -0,0 +1,10 @@
+-- AlterTable
+ALTER TABLE "gdhi"
+RENAME COLUMN "itllevel" TO "itl_level";
+
+-- AlterTable
+ALTER TABLE "gdhi"
+ALTER COLUMN "itl_level" SET NOT NULL,
+ALTER COLUMN "itl3" SET NOT NULL,
+ALTER COLUMN "region" SET NOT NULL,
+ALTER COLUMN "gdhi_2020" SET NOT NULL;
diff --git a/prisma/schema.prisma b/prisma/schema.prisma
@@ -20,10 +20,10 @@ model BuildPrices {
 
 model GDHI {
   id       Int     @id @default(autoincrement())
-  itlLevel String? @map("itllevel") @db.VarChar(250)
-  itl3     String? @db.VarChar(250)
-  region   String? @db.VarChar(250)
-  gdhi2020 Float?  @map("gdhi_2020")
+  itlLevel String  @map("itl_level") @db.VarChar(250)
+  itl3     String  @db.VarChar(250)
+  region   String  @db.VarChar(250)
+  gdhi2020 Float  @map("gdhi_2020")
 
   @@map("gdhi")
 }