fix: Use get() instead of 'this' in Zustand stores (#2250)

theopensystemslab · Oct 1, 2023 · 05a973f · 05a973f
1 parent 8d39f6f
commit 05a973f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/editor.planx.uk/src/pages/FlowEditor/lib/store/team.ts b/editor.planx.uk/src/pages/FlowEditor/lib/store/team.ts
@@ -54,7 +54,7 @@ export const teamStore: StateCreator<TeamStore, [], [], TeamStore> = (
     boundaryBBox: get().boundaryBBox,
   }),
 
-  async initTeamStore(teamSlugFromURLParams) {
+  initTeamStore: async (teamSlugFromURLParams) => {
     const slug = teamSlugFromURLParams || await getTeamFromDomain(window.location.hostname)
     const { data } = await client.query({
       query: gql`
@@ -86,7 +86,6 @@ export const teamStore: StateCreator<TeamStore, [], [], TeamStore> = (
     const team = data.teams[0];
 
     if (!team) throw new Error("Team not found");
-
-    this.setTeam(team);
+    get().setTeam(team);
   },
 });
diff --git a/editor.planx.uk/src/pages/FlowEditor/lib/store/user.ts b/editor.planx.uk/src/pages/FlowEditor/lib/store/user.ts
@@ -59,7 +59,7 @@ export const userStore: StateCreator<UserStore, [], [], UserStore> = (
     );
   },
 
-  async initUserStore(jwt: string) {
+  initUserStore: async (jwt: string) => {
     const email = (jwtDecode(jwt) as any)["email"];
     const users = await client.query({
       query: gql`
@@ -87,6 +87,6 @@ export const userStore: StateCreator<UserStore, [], [], UserStore> = (
     const user: User = users.data.users[0];
     if (!user) throw new Error(`Failed to get user ${email}`);
 
-    this.setUser(user);
+    get().setUser(user);
   },
 });
diff --git a/editor.planx.uk/src/routes/views/team.tsx b/editor.planx.uk/src/routes/views/team.tsx
@@ -13,7 +13,7 @@ export const teamView = async (req: NaviRequest) => {
     try {
       await initTeamStore(req.params.team);
     } catch (error) {
-      throw new NotFoundError("Team not found");
+      throw new NotFoundError(`Team not found: ${error}`);
     }
   }