chore: Bump planx-core, update _address type in passport (#3921)

theopensystemslab · Nov 7, 2024 · 280cfe0 · 280cfe0
1 parent 8a1c2db
commit 280cfe0
Show file tree

Hide file tree

Showing 10 changed files with 35 additions and 35 deletions.
diff --git a/api.planx.uk/package.json b/api.planx.uk/package.json
@@ -11,7 +11,7 @@
   },
   "dependencies": {
     "@airbrake/node": "^2.1.8",
-    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#839c7a0",
+    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#134b20d",
     "@types/isomorphic-fetch": "^0.0.36",
     "adm-zip": "^0.5.10",
     "aws-sdk": "^2.1467.0",

diff --git a/api.planx.uk/pnpm-lock.yaml b/api.planx.uk/pnpm-lock.yaml
diff --git a/e2e/tests/api-driven/package.json b/e2e/tests/api-driven/package.json
@@ -7,7 +7,7 @@
   "packageManager": "[email protected]",
   "dependencies": {
     "@cucumber/cucumber": "^9.3.0",
-    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#839c7a0",
+    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#134b20d",
     "axios": "^1.7.4",
     "dotenv": "^16.3.1",
     "dotenv-expand": "^10.0.0",

diff --git a/e2e/tests/api-driven/pnpm-lock.yaml b/e2e/tests/api-driven/pnpm-lock.yaml
diff --git a/e2e/tests/ui-driven/package.json b/e2e/tests/ui-driven/package.json
@@ -8,7 +8,7 @@
     "postinstall": "./install-dependencies.sh"
   },
   "dependencies": {
-    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#839c7a0",
+    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#134b20d",
     "axios": "^1.7.4",
     "dotenv": "^16.3.1",
     "eslint": "^8.56.0",

diff --git a/e2e/tests/ui-driven/pnpm-lock.yaml b/e2e/tests/ui-driven/pnpm-lock.yaml
diff --git a/editor.planx.uk/package.json b/editor.planx.uk/package.json
@@ -15,7 +15,7 @@
     "@mui/material": "^5.15.10",
     "@mui/utils": "^5.15.11",
     "@opensystemslab/map": "1.0.0-alpha.4",
-    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#839c7a0",
+    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#134b20d",
     "@tiptap/core": "^2.4.0",
     "@tiptap/extension-bold": "^2.0.3",
     "@tiptap/extension-bubble-menu": "^2.1.13",

diff --git a/editor.planx.uk/pnpm-lock.yaml b/editor.planx.uk/pnpm-lock.yaml
diff --git a/editor.planx.uk/src/@planx/components/FindProperty/Public/Autocomplete.tsx b/editor.planx.uk/src/@planx/components/FindProperty/Public/Autocomplete.tsx
@@ -85,26 +85,26 @@ export default function PickOSAddress(props: PickOSAddressProps): FCReturn {
             selectedAddress.SAO_TEXT, // populated in cases of building name only, no street number
           ]
             .filter(Boolean)
-            .join(""),
+            .join("") || undefined,
           saoEnd: [
             selectedAddress.SAO_END_NUMBER,
             selectedAddress.SAO_END_SUFFIX,
           ]
             .filter(Boolean)
-            .join(""),
+            .join("") || undefined,
           pao: [
             selectedAddress.PAO_START_NUMBER,
             selectedAddress.PAO_START_SUFFIX,
             selectedAddress.PAO_TEXT, // populated in cases of building name only, no street number
           ]
             .filter(Boolean)
-            .join(""),
+            .join("") || undefined,
           paoEnd: [
             selectedAddress.PAO_END_NUMBER,
             selectedAddress.PAO_END_SUFFIX,
           ]
             .filter(Boolean)
-            .join(""),
+            .join("") || undefined,
           street: selectedAddress.STREET_DESCRIPTION,
           town: selectedAddress.TOWN_NAME,
           postcode: selectedAddress.POSTCODE_LOCATOR,

diff --git a/editor.planx.uk/src/@planx/components/FindProperty/model.ts b/editor.planx.uk/src/@planx/components/FindProperty/model.ts
@@ -52,8 +52,8 @@ export interface SiteAddress extends MinimumSiteAddress {
   usrn?: string;
   blpu_code?: string;
   organisation?: string | null;
-  sao?: string | null;
-  saoEnd?: string | null;
+  sao?: string;
+  saoEnd?: string;
   pao?: string;
   paoEnd?: string;
   street?: string;