Reword error message and remove min max from validation

theopensystemslab · Nov 12, 2024 · 805f030 · 805f030
1 parent cbff416
commit 805f030
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/editor.planx.uk/src/@planx/components/Feedback/Public/tests/Public.submit.test.tsx b/editor.planx.uk/src/@planx/components/Feedback/Public/tests/Public.submit.test.tsx
@@ -87,7 +87,7 @@ describe("when feedback is required but the user does not submit any data", asyn
 
   it("displays an appropriate error message for each missing field", async () => {
     const errorMessages = [
-      "Please provide a feedback score",
+      "Please rate your experience",
       "Enter your feedback",
     ];
     errorMessages.map((error) => {

diff --git a/editor.planx.uk/src/@planx/components/Feedback/model.ts b/editor.planx.uk/src/@planx/components/Feedback/model.ts
@@ -34,14 +34,7 @@ export const createFeedbackSchema = (feedbackRequired: boolean) => {
       ? string().required("Enter your feedback")
       : string(),
     feedbackScore: feedbackRequired
-      ? number()
-          .integer()
-          .min(1, "Feedback score must be at least 1")
-          .max(5, "Feedback score cannot exceed 5")
-          .required("Please provide a feedback score")
-      : number()
-          .integer()
-          .min(1, "Feedback score must be at least 1")
-          .max(5, "Feedback score cannot exceed 5"),
+      ? number().integer().required("Please rate your experience")
+      : number().integer(),
   });
 };