chore: Stream S3 files directly to zip (#2380)

theopensystemslab · Nov 18, 2023 · 96adf16 · 96adf16
1 parent 70ac017
commit 96adf16
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/api.planx.uk/send/exportZip.test.ts b/api.planx.uk/send/exportZip.test.ts
@@ -7,7 +7,6 @@ jest.mock("fs", () => ({
   existsSync: () => true,
   unlinkSync: () => undefined,
   createWriteStream: () => undefined,
-  writeFileSync: () => undefined,
   rmSync: () => undefined,
 }));
 

diff --git a/api.planx.uk/send/exportZip.ts b/api.planx.uk/send/exportZip.ts
@@ -197,9 +197,7 @@ export class ExportZip {
       throw new Error("file not found");
     }
     const filePath = path.join(this.tmpDir, name);
-    fs.writeFileSync(filePath, body as Buffer);
-    this.zip.addLocalFile(filePath);
-    fs.unlinkSync(filePath);
+    this.zip.addFile(filePath, body as Buffer);
   }
 
   toBuffer(): Buffer {