chore: make feature flag check static

- As per: #2632 (comment)
theopensystemslab · Jan 18, 2024 · adcb8c2 · adcb8c2
1 parent aa17f63
commit adcb8c2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/editor.planx.uk/src/@planx/components/shared/Preview/MoreInfo.tsx b/editor.planx.uk/src/@planx/components/shared/Preview/MoreInfo.tsx
@@ -62,7 +62,7 @@ const CloseButton = styled(Box)(({ theme }) => ({
   color: theme.palette.text.primary,
 }));
 
-const isUsingFeatureFlag = () => hasFeatureFlag("SHOW_INTERNAL_FEEDBACK");
+const isUsingFeatureFlag = hasFeatureFlag("SHOW_INTERNAL_FEEDBACK");
 
 interface IMoreInfo {
   open: boolean;
@@ -98,7 +98,7 @@ const MoreInfo: React.FC<IMoreInfo> = ({ open, children, handleClose }) => (
     <Container maxWidth={false} role="main" sx={{ bgcolor: "white" }}>
       <DrawerContent>{children}</DrawerContent>
     </Container>
-    {isUsingFeatureFlag() && <MoreInfoFeedbackComponent />}
+    {isUsingFeatureFlag && <MoreInfoFeedbackComponent />}
   </Root>
 );
 

diff --git a/editor.planx.uk/src/pages/layout/PublicLayout.tsx b/editor.planx.uk/src/pages/layout/PublicLayout.tsx
@@ -65,11 +65,11 @@ const PublicFooter: React.FC = () => {
       Boolean(item),
   );
 
-  const isUsingFeatureFlag = () => hasFeatureFlag("SHOW_INTERNAL_FEEDBACK");
+  const isUsingFeatureFlag = hasFeatureFlag("SHOW_INTERNAL_FEEDBACK");
 
   return (
     <Box>
-      {isUsingFeatureFlag() ? <Feedback /> : <PhaseBanner />}
+      {isUsingFeatureFlag ? <Feedback /> : <PhaseBanner />}
       <Footer items={[...footerItems]}>
         <Box display="flex" alignItems="center">
           <Box pr={2} display="flex">