From e86955c8616bae3348ab98d4ed330fef25d4aba5 Mon Sep 17 00:00:00 2001 From: zz-hh-aa Date: Tue, 28 Jan 2025 13:28:49 +0000 Subject: [PATCH] nit: fix comment and validation --- .../modules/analytics/metabase/collection/service.ts | 5 ----- api.planx.uk/modules/analytics/metabase/collection/types.ts | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/api.planx.uk/modules/analytics/metabase/collection/service.ts b/api.planx.uk/modules/analytics/metabase/collection/service.ts index 8d4296718c..1de3b9223c 100644 --- a/api.planx.uk/modules/analytics/metabase/collection/service.ts +++ b/api.planx.uk/modules/analytics/metabase/collection/service.ts @@ -3,11 +3,6 @@ import type { NewCollectionParams } from "./types.js"; import { getTeamIdAndMetabaseId } from "./getTeamIdAndMetabaseId.js"; import { createCollection } from "./createCollection.js"; -/** - * The `getTeamIdAndMetabaseId()` function is run here to first get teams.id and .metabase_id from PlanX db, if present, - * so that the service can figure out if it needs to run `createCollection()` or not. - * Instead of running `getTeamIdAndMetabaseId()` first in the controller, it is encapsulated in `createTeamCollection` to keep business logic in `service.ts` instead of `controller.ts`. - */ export async function createTeamCollection({ slug, parentId, diff --git a/api.planx.uk/modules/analytics/metabase/collection/types.ts b/api.planx.uk/modules/analytics/metabase/collection/types.ts index 2f21a43faf..db288903e4 100644 --- a/api.planx.uk/modules/analytics/metabase/collection/types.ts +++ b/api.planx.uk/modules/analytics/metabase/collection/types.ts @@ -23,7 +23,7 @@ export type MetabaseCollectionParams = Omit & { export const createTeamCollectionSchema = z.object({ params: z.object({ - slug: z.string(), + slug: z.string().min(1), }), body: z.object({ description: z.string().optional(),