better types

theopensystemslab · Nov 29, 2024 · ea34817 · ea34817
1 parent 6219c4f
commit ea34817
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/editor.planx.uk/src/@planx/components/List/utils.tsx b/editor.planx.uk/src/@planx/components/List/utils.tsx
@@ -16,7 +16,7 @@ const List = styled("ul")(() => ({
  * @returns string | React.JSX.Element - the `text` for the given value `val`, or the original value
  */
 export function formatSchemaDisplayValue(
-  value: string | string[] | Record<string, string>,
+  value: string | string[],
   field: Field,
 ) {
   switch (field.type) {

diff --git a/editor.planx.uk/src/@planx/components/shared/Schema/InputFields/AddressFieldInput.tsx b/editor.planx.uk/src/@planx/components/shared/Schema/InputFields/AddressFieldInput.tsx
@@ -1,9 +1,6 @@
 import Box from "@mui/material/Box";
 import Typography from "@mui/material/Typography";
-import {
-  AddressFields,
-  FormProps,
-} from "@planx/components/AddressInput/Public";
+import { AddressFields } from "@planx/components/AddressInput/Public";
 import React from "react";
 import InputLegend from "ui/editor/InputLegend";
 
@@ -27,7 +24,7 @@ export const AddressFieldInput: React.FC<Props<AddressField>> = (props) => {
       )}
       <AddressFields
         id={id}
-        values={value as unknown as FormProps}
+        values={value}
         errors={errorMessage}
         handleChange={formik.handleChange}
       />

diff --git a/editor.planx.uk/src/@planx/components/shared/Schema/model.ts b/editor.planx.uk/src/@planx/components/shared/Schema/model.ts
@@ -130,8 +130,8 @@ export interface Schema {
 
 export type SchemaUserResponse = Record<
   Field["data"]["fn"],
-  string | string[] | Record<string, string> | any[]
->; // string | string[] | Record<string, string> | Feature[]
+  string | string[] | any
+>; // string | string[] | Record<string, string> (address field) | Feature[] (map field)
 
 /**
  * Output data from a form using the useSchema hook