From f211e05fa71240cd14921d5a21143a7a01082116 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dafydd=20Ll=C5=B7r=20Pearson?= <DafyddLlyr@gmail.com>
Date: Wed, 20 Nov 2024 16:49:46 +0000
Subject: [PATCH] chore: Move Pay default values to model

---
 .../@planx/components/Pay/Editor/Editor.tsx   | 50 +------------------
 .../src/@planx/components/Pay/model.ts        | 40 ++++++++++++++-
 2 files changed, 41 insertions(+), 49 deletions(-)

diff --git a/editor.planx.uk/src/@planx/components/Pay/Editor/Editor.tsx b/editor.planx.uk/src/@planx/components/Pay/Editor/Editor.tsx
index 0d2c844252..8f0a9fbb6c 100644
--- a/editor.planx.uk/src/@planx/components/Pay/Editor/Editor.tsx
+++ b/editor.planx.uk/src/@planx/components/Pay/Editor/Editor.tsx
@@ -2,12 +2,11 @@ import {
   ComponentType as TYPES,
 } from "@opensystemslab/planx-core/types";
 import {
+  parsePay,
   Pay,
   validationSchema,
 } from "@planx/components/Pay/model";
-import { parseBaseNodeData } from "@planx/components/shared";
 import { Form, Formik } from "formik";
-import { useStore } from "pages/FlowEditor/lib/store";
 import React from "react";
 import { ComponentTagSelect } from "ui/editor/ComponentTagSelect";
 import { InternalNotes } from "ui/editor/InternalNotes";
@@ -27,51 +26,6 @@ import { InviteToPaySection } from "./InviteToPaySection";
 export type Props = EditorProps<TYPES.Pay, Pay>;
 
 const Component: React.FC<Props> = (props: Props) => {
-  const [flowName] = useStore((store) => [store.flowName]);
-  const initialValues: Pay = {
-    title: props.node?.data?.title || "Pay for your application",
-    bannerTitle:
-      props.node?.data?.bannerTitle ||
-      "The planning fee for this application is",
-    description:
-      props.node?.data?.description ||
-      `<p>The planning fee covers the cost of processing your application.\
-         <a href="https://www.gov.uk/guidance/fees-for-planning-applications" target="_self">Find out more about how planning fees are calculated</a> (opens in new tab).</p>`,
-    fn: props.node?.data?.fn,
-    instructionsTitle: props.node?.data?.instructionsTitle || "How to pay",
-    instructionsDescription:
-      props.node?.data?.instructionsDescription ||
-      `<p>You can pay for your application by using GOV.UK Pay.</p>\
-         <p>Your application will be sent after you have paid the fee. \
-         Wait until you see an application sent message before closing your browser.</p>`,
-    hidePay: props.node?.data?.hidePay || false,
-    allowInviteToPay: props.node?.data?.allowInviteToPay ?? true,
-    secondaryPageTitle:
-      props.node?.data?.secondaryPageTitle ||
-      "Invite someone else to pay for this application",
-    nomineeTitle:
-      props.node?.data?.nomineeTitle || "Details of the person paying",
-    nomineeDescription: props.node?.data?.nomineeDescription,
-    yourDetailsTitle: props.node?.data?.yourDetailsTitle || "Your details",
-    yourDetailsDescription: props.node?.data?.yourDetailsDescription,
-    yourDetailsLabel:
-      props.node?.data?.yourDetailsLabel || "Your name or organisation name",
-    govPayMetadata: props.node?.data?.govPayMetadata || [
-      {
-        key: "flow",
-        value: flowName,
-      },
-      {
-        key: "source",
-        value: "PlanX",
-      },
-      {
-        key: "paidViaInviteToPay",
-        value: "@paidViaInviteToPay",
-      },
-    ],
-    ...parseBaseNodeData(props.node?.data),
-  };
 
   const onSubmit = (newValues: Pay) => {
     if (props.handleSubmit) {
@@ -81,7 +35,7 @@ const Component: React.FC<Props> = (props: Props) => {
 
   return (
     <Formik<Pay>
-      initialValues={initialValues}
+      initialValues={parsePay(props.node?.data)}
       onSubmit={onSubmit}
       validationSchema={validationSchema}
       validateOnChange={true}
diff --git a/editor.planx.uk/src/@planx/components/Pay/model.ts b/editor.planx.uk/src/@planx/components/Pay/model.ts
index bc63edf279..0a905ce14f 100644
--- a/editor.planx.uk/src/@planx/components/Pay/model.ts
+++ b/editor.planx.uk/src/@planx/components/Pay/model.ts
@@ -8,7 +8,7 @@ import { useStore } from "pages/FlowEditor/lib/store";
 import { ApplicationPath, Passport } from "types";
 import { array, boolean, object, string } from "yup";
 
-import type { BaseNodeData } from "../shared";
+import { parseBaseNodeData, type BaseNodeData } from "../shared";
 
 export interface Pay extends BaseNodeData {
   title: string;
@@ -164,3 +164,41 @@ export const validationSchema = object({
   }),
   govPayMetadata: govPayMetadataSchema,
 });
+
+export const getDefaultContent = (): Pay => ({
+  title: "Pay for your application",
+  bannerTitle: "The planning fee for this application is",
+  fn: "application.fee.payable",
+  description: `<p>The planning fee covers the cost of processing your application.\
+    <a href="https://www.gov.uk/guidance/fees-for-planning-applications" target="_self">Find out more about how planning fees are calculated</a> (opens in new tab).</p>`,
+  instructionsTitle: "How to pay",
+  instructionsDescription: `<p>You can pay for your application by using GOV.UK Pay.</p>\
+    <p>Your application will be sent after you have paid the fee. \
+    Wait until you see an application sent message before closing your browser.</p>`,
+  hidePay: false,
+  allowInviteToPay: true,
+  secondaryPageTitle: "Invite someone else to pay for this application",
+  nomineeTitle: "Details of the person paying",
+  yourDetailsTitle: "Your details",
+  yourDetailsLabel: "Your name or organisation name",
+  govPayMetadata: [
+    {
+      key: "flow",
+      value: useStore.getState().flowName,
+    },
+    {
+      key: "source",
+      value: "PlanX",
+    },
+    {
+      key: "paidViaInviteToPay",
+      value: "@paidViaInviteToPay",
+    },
+  ],
+});
+
+export const parsePay = (data?: Record<string, any>): Pay => ({
+  ...parseBaseNodeData(data),
+  ...getDefaultContent(),
+  ...data,
+});