From 64bc210398f4e1d7ef457aa8a272779c191de088 Mon Sep 17 00:00:00 2001 From: Jessica McInchak Date: Fri, 6 Sep 2024 16:14:00 +0200 Subject: [PATCH] remove feature flag --- .../src/@planx/components/List/Editor.tsx | 12 ++++-------- editor.planx.uk/src/lib/featureFlags.ts | 2 +- .../pages/FlowEditor/components/forms/FormModal.tsx | 4 +--- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/editor.planx.uk/src/@planx/components/List/Editor.tsx b/editor.planx.uk/src/@planx/components/List/Editor.tsx index bd4d1b87ec..1771b8b36a 100644 --- a/editor.planx.uk/src/@planx/components/List/Editor.tsx +++ b/editor.planx.uk/src/@planx/components/List/Editor.tsx @@ -25,12 +25,12 @@ import { ProtectedSpaceGLA } from "./schemas/GLA/ProtectedSpace"; import { MaterialDetails } from "./schemas/Materials"; import { Parking } from "./schemas/Parking"; import { ResidentialUnitsExisting } from "./schemas/ResidentialUnits/Existing"; +import { ResidentialUnitsGLAGained } from "./schemas/ResidentialUnits/GLA/Gained"; +import { ResidentialUnitsGLALost } from "./schemas/ResidentialUnits/GLA/Lost"; import { ResidentialUnitsGLANew } from "./schemas/ResidentialUnits/GLA/New"; import { ResidentialUnitsGLARebuilt } from "./schemas/ResidentialUnits/GLA/Rebuilt"; import { ResidentialUnitsGLARemoved } from "./schemas/ResidentialUnits/GLA/Removed"; import { ResidentialUnitsGLARetained } from "./schemas/ResidentialUnits/GLA/Retained"; -import { ResidentialUnitsGLALost } from "./schemas/ResidentialUnits/GLA/Lost"; -import { ResidentialUnitsGLAGained } from "./schemas/ResidentialUnits/GLA/Gained"; import { ResidentialUnitsProposed } from "./schemas/ResidentialUnits/Proposed"; import { Trees } from "./schemas/Trees"; import { TreesMapFirst } from "./schemas/TreesMapFirst"; @@ -77,12 +77,8 @@ export const SCHEMAS = [ { name: "Proposed advertisements", schema: ProposedAdvertisements }, { name: "Parking details", schema: Parking }, { name: "Parking details (GLA)", schema: ParkingGLA }, - ...(hasFeatureFlag("TREES") - ? [ - { name: "Trees", schema: Trees }, - { name: "Trees (Map first)", schema: TreesMapFirst }, - ] - : []), + { name: "Trees", schema: Trees }, + { name: "Trees (Map first)", schema: TreesMapFirst }, ]; function ListComponent(props: Props) { diff --git a/editor.planx.uk/src/lib/featureFlags.ts b/editor.planx.uk/src/lib/featureFlags.ts index 0d2ad35ca5..b1e478c760 100644 --- a/editor.planx.uk/src/lib/featureFlags.ts +++ b/editor.planx.uk/src/lib/featureFlags.ts @@ -1,5 +1,5 @@ // add/edit/remove feature flags in array below -const AVAILABLE_FEATURE_FLAGS = ["SEARCH", "TREES", "ADD_NEW_EDITOR"] as const; +const AVAILABLE_FEATURE_FLAGS = ["SEARCH", "ADD_NEW_EDITOR"] as const; type FeatureFlag = (typeof AVAILABLE_FEATURE_FLAGS)[number]; diff --git a/editor.planx.uk/src/pages/FlowEditor/components/forms/FormModal.tsx b/editor.planx.uk/src/pages/FlowEditor/components/forms/FormModal.tsx index ebcbdfe382..79564d537e 100644 --- a/editor.planx.uk/src/pages/FlowEditor/components/forms/FormModal.tsx +++ b/editor.planx.uk/src/pages/FlowEditor/components/forms/FormModal.tsx @@ -62,9 +62,7 @@ const NodeTypeSelect: React.FC<{ - {hasFeatureFlag("TREES") && ( - - )} +