Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kwalitee fixes #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/SVN/Notify.pm
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package SVN::Notify;

use strict;
use warnings;
require 5.006_000;
use constant WIN32 => $^O eq 'MSWin32';
use constant PERL58 => $] > 5.007_000;
Expand Down Expand Up @@ -1694,7 +1695,7 @@ sub output_file_lists {

$notifier->end_body($file_handle);

Closes out the body of the email by outputting the contents of the C<footer>
Closes out the body of the email by emitting the contents of the C<footer>
attribute, if any, and then a couple of newlines. Designed to be called when
the body of the message is complete, and before any call to
C<output_attached_diff()>.
Expand Down
3 changes: 2 additions & 1 deletion lib/SVN/Notify/Alternative.pm
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
package SVN::Notify::Alternative;

use strict;
use warnings;
use SVN::Notify ();

$SVN::Notify::Alternative::VERSION = '1.0';
$SVN::Notify::Alternative::VERSION = '2.87';
@SVN::Notify::Alternative::ISA = qw(SVN::Notify);

__PACKAGE__->register_attributes(
Expand Down
8 changes: 4 additions & 4 deletions lib/SVN/Notify/Filter.pod
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ certain messages (not a good idea, but what the hell?):

=item * Uppercase meta data labels

Change the format of the commit meta data section of the message to uppercase
Change the format of the commit meta data section of the message to upcase
all of the headers, so that "Revision: 111" becomes "REVISION: 111":

Note that this example also makes use of the C<content_type()> method of
Expand Down Expand Up @@ -256,7 +256,7 @@ Just to demonstrate how to filter file lists:
This one is a little more complicated because diff filters need to return a
file handle. SVN::Notify tries to be as efficient with resources as it can, so
it reads each line of the diff from the file handle one-at-a-time, processing
and outputting each in turn so as to avoid loading the entire diff into
and emitting each in turn so as to avoid loading the entire diff into
memory. To retain this pattern, the best approach is to tie the file handle to
a class that does the filtering one line at a time. The requisite C<tie> class
needs only three methods: C<TIEHANDLE> C<READLINE>, and C<CLOSE>. In this
Expand Down Expand Up @@ -313,11 +313,11 @@ module to do the same thing:
}

But do beware of this approach if you're likely to commit changes that would
generate very larges diffs!
generate very large diffs!

=item * Filter based on parameter

You can also add attributes (and therefor command-line options) to SVN::Notify
You can also add attributes (and thus command-line options) to SVN::Notify
in your filter in order to alter its behavior. This is precisely what the
included L<SVN::Notify::Filter::Trac|SVN::Notify::Filter::Trac> module does:
it adds a new attribute, C<trac_url()>, so that it can create the proper Trac
Expand Down
1 change: 1 addition & 0 deletions lib/SVN/Notify/Filter/Trac.pm
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package SVN::Notify::Filter::Trac;

use strict;
use warnings;
use Text::Trac;
use SVN::Notify;

Expand Down
3 changes: 2 additions & 1 deletion lib/SVN/Notify/HTML.pm
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package SVN::Notify::HTML;

use strict;
use warnings;
use HTML::Entities;
use SVN::Notify ();

Expand Down Expand Up @@ -468,7 +469,7 @@ sub output_file_lists {

$notifier->end_body($file_handle);

Closes out the body of the email by outputting the closing C<< </body> >> and
Closes out the body of the email by emitting the closing C<< </body> >> and
C<< </html> >> tags. Designed to be called when the body of the message is
complete, and before any call to C<output_attached_diff()>.

Expand Down
1 change: 1 addition & 0 deletions lib/SVN/Notify/HTML/ColorDiff.pm
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package SVN::Notify::HTML::ColorDiff;

use strict;
use warnings;
use HTML::Entities;
use SVN::Notify::HTML ();

Expand Down
12 changes: 12 additions & 0 deletions t/pod-spelling.t
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,15 @@ GitHub
TLS
auth
SMTP
8bit
Big5
HTML
RT
SourceForge.net
email
meta
rt
i.e
Uppercase
e.g
uppercase