Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads-up: -Csoft-float is a NOP on the targets you support (and will soon be deprecated) #11

Closed
RalfJung opened this issue Nov 13, 2024 · 3 comments

Comments

@RalfJung
Copy link

I stumbled upon this use of -Csoft-float:

RUSTFLAGS += -C soft-float # Disables requiring SSE etc

This flag is a NOP on all targets except for 32bit ARM *hf targets. Given that the docs say "the current version is x86_64/amd64", it should be the case that this flag can be removed without any change in behavior. In particular, to my knowledge the comment indicating that this avoids the use of SSE on x86 targets is incorrect. See rust-lang/rust#129893 for more context.

thepowersgang added a commit that referenced this issue Dec 6, 2024
@thepowersgang
Copy link
Owner

@RalfJung Does that apply to the soft-float target feature? (in the JSON target spec)?

@RalfJung
Copy link
Author

RalfJung commented Dec 7, 2024

No, this is entirely about the -C flag.

The soft-float target feature has some issues (see rust-lang/rust#116344), but it does have an effect, and our plan is to keep allowing it for the cases where it is sound and error only when it is unsound. (And it will always be usable in the JSON target spec, that is the safest place to set it.)

@thepowersgang
Copy link
Owner

That was removed in d4d558c, so cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants