From 88bcb510e95a1ee3a87418aaae1902284f4e0a53 Mon Sep 17 00:00:00 2001 From: Jakub Nowakowski Date: Fri, 10 May 2024 15:18:44 +0200 Subject: [PATCH] Prefix internal function with underscore Prefix internal function with underscore as per the [style guide](https://docs.soliditylang.org/en/latest/style-guide.html#underscore-prefix-for-non-external-functions-and-variables). --- solidity/contracts/BitcoinRedeemer.sol | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/solidity/contracts/BitcoinRedeemer.sol b/solidity/contracts/BitcoinRedeemer.sol index 9ba2c33d5..5cf865f51 100644 --- a/solidity/contracts/BitcoinRedeemer.sol +++ b/solidity/contracts/BitcoinRedeemer.sol @@ -52,7 +52,7 @@ contract BitcoinRedeemer is Ownable2StepUpgradeable, IReceiveApproval { /// Attempted to call receiveApproval with empty data. error EmptyExtraData(); - /// Attempted to call redeemSharesAndUnmint with unexpected tBTC token owner. + /// Attempted to call _redeemSharesAndUnmint with unexpected tBTC token owner. error UnexpectedTbtcTokenOwner(); /// Reverts if the redeemer is not the deposit owner. @@ -111,7 +111,7 @@ contract BitcoinRedeemer is Ownable2StepUpgradeable, IReceiveApproval { if (msg.sender != address(stbtc)) revert CallerNotAllowed(msg.sender); if (extraData.length == 0) revert EmptyExtraData(); - redeemSharesAndUnmint(from, amount, extraData); + _redeemSharesAndUnmint(from, amount, extraData); } /// @notice Updates TBTCVault contract address. @@ -151,7 +151,7 @@ contract BitcoinRedeemer is Ownable2StepUpgradeable, IReceiveApproval { /// @param tbtcRedemptionData Additional data required for the tBTC redemption. /// See `redemptionData` parameter description of `Bridge.requestRedemption` /// function. - function redeemSharesAndUnmint( + function _redeemSharesAndUnmint( address owner, uint256 shares, bytes calldata tbtcRedemptionData