Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear styles for dApp layout #893

Open
kkosiorowska opened this issue Nov 22, 2024 · 1 comment
Open

Clear styles for dApp layout #893

kkosiorowska opened this issue Nov 22, 2024 · 1 comment

Comments

@kkosiorowska
Copy link
Contributor

kkosiorowska commented Nov 22, 2024

During work on #892, I noticed that the change padding needed to be made in 3 places to keep the layout consistent. Padding should be set once to make it easier to manage layout styles. Additionally, the header and footer have the same value for maxW, a possible change also requires updating the two styles in completely different places.

maxW="120rem" // 1920px
mx="auto"
justify="space-between"
zIndex="header"
pt={12}
pb={{ base: 4, xl: 12 }}
px={{ base: 10, xl: 30 }}

maxW: "120rem", // 1920px
py: 3,
px: { base: 10, xl: 30 },

Let's update the Layout component and simplify the styles for Header, Footer and main content.

Copy link

linear bot commented Nov 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant