ASoC: Intel: sof_rt5682: Add support for Rex with discrete BT offload. #4551
Conversation
udaymb
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao,
ujfalusi,
vijendarmukunda,
kuanhsuncheng and
yaochunhung
as code owners
sound/soc/intel/boards/sof_rt5682.c
Outdated
| SOF_SPEAKER_AMP_PRESENT | | ||
| SOF_MAX98360A_SPEAKER_AMP_PRESENT | | ||
| SOF_RT5682_SSP_AMP(0) | | ||
| SOF_RT5682_NUM_HDMIDEV(4) | |
There was a problem hiding this comment.
@plbossart Do we want to support 4 HDMI on MTL I2S machines?
There was a problem hiding this comment.
no, we added 3 only in topology2 files.
There was a problem hiding this comment.
no, we added 3 only in topology2 files.
@udaymb, then SOF_RT5682_NUM_HDMIDEV should be 3, and same as line 222.
There was a problem hiding this comment.
Can we add a quirk SOF_PDM_NUM_CHANNELS() and load the 2ch and 4ch topologies accordingly based on the DMI information?
There was a problem hiding this comment.
This quirk is not necessary since SOF_SPEAKER_AMP_PRESENT and SOF_*_SPEAKER_AMP_PRESENT are removed.
There was a problem hiding this comment.
Need to change SPK_ID to 6 in topology cmake file if changing HDMIDEV to 3 or amplifier BE ID will mismatch.
There was a problem hiding this comment.
Updated topology - thesofproject/sof#8131
|
As I know we only support CNVI BT, not discrete. Things change? |
Yes, both integrated and discrete are supported on Rex models. |
This is also CNVI BT - but its discrete, compared to earlier integrated BT, for discrete BT there is additional change in the system firmware - handled as part of this patch https://review.coreboot.org/c/coreboot/+/77357. This will set additional gpio configuration compared to integrated BT offload. So, system firmware has introduced additional dmi match for this scenario. Hence, this needs to be handled in Kernel to match this device |
System firmware has included additional audio DMI string MAX98360_ALC5682I_DISCRETE_I2S_BT for discrete BT offload supporting devices. Same DMI string match is introduced in sof_rt5682_quirk_table. Signed-off-by: Uday M Bhat <[email protected]>
For all MTL/Rex devices, number of HDMI supported is 3. Signed-off-by: Yong Zhi <[email protected]> Signed-off-by: Uday M Bhat <[email protected]>
System firmware has included additional audio DMI string MAX98360_ALC5682I_DISCRETE_I2S_BT for discrete BT offload supporting devices. Same DMI string match is introduced in sof_rt5682_quirk_table.
DMI match is introduced as per the changes in https://review.coreboot.org/c/coreboot/+/77357