Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] No kernel boot log when SOF FW loading fails #1036

Closed
fredoh9 opened this issue May 15, 2023 · 3 comments
Closed

[BUG] No kernel boot log when SOF FW loading fails #1036

fredoh9 opened this issue May 15, 2023 · 3 comments
Assignees
Labels
P2 Critical bugs or normal features type:bug Something doesn't work as expected

Comments

@fredoh9
Copy link
Collaborator

fredoh9 commented May 15, 2023

Describe the bug
No kernel log is captured in test result. This is side effect after #1033 merged.
'start_test' will be called before the every test case, if it fails there, too early to capture the log

To Reproduce
This is one of example, FW loading is failed
https://sof-ci.01.org/sofpr/PR7584/build7585/devicetest/index.html?model=ADLP_RVP_SDW_IPC4ZPH&testcase=verify-kernel-boot-log

Expected behavior
kernel log should be available on the failure

@fredoh9 fredoh9 added the bug label May 15, 2023
@marc-hb
Copy link
Collaborator

marc-hb commented May 15, 2023

Originally posted by @marc-hb in #1033 (comment)

I think @lyakh found an issue with this new feature: kernel logs seem to be missing when the firmware does not boot. Example: https://sof-ci.01.org/sofpr/PR7584/build7585/devicetest/index.html

In jenkins logs generic_test/13429/

10:58:40  cmd: scp -r [email protected]:~/sof-test/test-case/../logs/verify-firmware-presence/last/* results/2023-05-12-03:55:59/sh-adlp-rvp-sdw-01/verify-firmware-presence
10:58:40  return code: 1
10:58:40  cmd output: scp: /home/ubuntu/sof-test/test-case/../logs/verify-firmware-presence/last/*: No such file or directory

This is very likely because the new code runs "too early".

@marc-hb marc-hb added type:bug Something doesn't work as expected and removed bug labels May 17, 2023
@marc-hb marc-hb added the P2 Critical bugs or normal features label Jun 22, 2023
@marc-hb marc-hb self-assigned this Apr 9, 2024
marc-hb added a commit to marc-hb/sof-test that referenced this issue May 8, 2024
Provide a new, boot_logs.txt file no matter what happens. Note that file
now includes user-space logs, not just kernel logs.

Also: fix bug where script times out and does not run when the SOF
firmware is not loaded: no need to define NO_POLL_FW_LOADING anymore.

The trick is to stop calling `start_test()`. verify-kernel-boot-log.sh
is not an audio test!

Fixes sof-test issues thesofproject#1036 and thesofproject#1112, find more details there.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb
Copy link
Collaborator

marc-hb commented May 8, 2024

Fix submitted: #1191

marc-hb added a commit that referenced this issue May 9, 2024
Provide a new, boot_logs.txt file no matter what happens. Note that file
now includes user-space logs, not just kernel logs.

Also: fix bug where script times out and does not run when the SOF
firmware is not loaded: no need to define NO_POLL_FW_LOADING anymore.

The trick is to stop calling `start_test()`. verify-kernel-boot-log.sh
is not an audio test!

Fixes sof-test issues #1036 and #1112, find more details there.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb
Copy link
Collaborator

marc-hb commented May 10, 2024

Should be good, will re-open if any issue.

@marc-hb marc-hb closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Critical bugs or normal features type:bug Something doesn't work as expected
Projects
None yet
Development

No branches or pull requests

2 participants