Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tplgtool2.py: show widget CPC in topology graph #1099

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

aiChaoSONG
Copy link

@aiChaoSONG aiChaoSONG commented Sep 6, 2023

This patch adds support to show widget CPC value
int topology graph.

sof-hda-generic-4ch

@aiChaoSONG aiChaoSONG requested a review from a team as a code owner September 6, 2023 03:01
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you:

  • Share a sample screenshot in the PR?
  • Split in 2 commits? First the no-op refactor, second commit adds the new feature.

Chao Song added 2 commits September 6, 2023 13:12
A widget could have multiple tokens, core ID is only
one of them. Instead of using a specific get_core_id()
function, add and use a generic token value getter for
core ID.

This patch also remove specific get_core_id() function.

Signed-off-by: Chao Song <[email protected]>
This patch adds support to show widget CPC value
int topology graph.

Signed-off-by: Chao Song <[email protected]>
@aiChaoSONG aiChaoSONG merged commit 8da6029 into thesofproject:main Sep 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants