Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] vmh_test_single test fails #8629

Open
kv2019i opened this issue Dec 14, 2023 · 7 comments
Open

[BUG] vmh_test_single test fails #8629

kv2019i opened this issue Dec 14, 2023 · 7 comments
Assignees
Labels
bug Something isn't working as expected MTL Applies to Meteor Lake platform

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Dec 14, 2023

Describe the bug
vmh_test_single() test in work/sof/zephyr/test/vmh.c fails.

To Reproduce

  • uncomment SOF_BOOT_TEST and ZTEST in sof/app/debug_overlay.conf
  • build SOF with debug enabled "-d"
  • boot FW, test is run on boot

Reproduction Rate
100%

Expected behavior
Test should pass

Impact
The failing test caused DSP panics in #8621 . The relation is not fully understood yet, but potentially vmh error can have serious side-impacts that we need to understand

Environment

  1. Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
    • Kernel: 20231213 daily
    • SOF: af3fa41 (SOF main)
  2. Name of the topology file
    • Topology: n/a
  3. Name of the platform(s) on which the bug is observed.
    • Platform: Intel mtl

Screenshots or console output

Running TESTSUITE sof_boot
===================================================================
START - virtual_memory_heap
[    0.505716] <wrn> sof_boot_test: vmh_test_single: Ignoring failure to allocate 1616 in non-contiguous mode
[    0.505723] <err> sof_boot_test: vmh_test_single: Failed to allocate 26
[    0.505845] <err> sof_boot_test: vmh_test: Non-contiguous test error -12
[    0.505850] <err> sof_boot_test: sof_boot_virtual_memory_heap: virtual_memory_heap failed: -12
 FAIL - virtual_memory_heap in 0.001 seconds
===================================================================

#8621 (comment)

@kv2019i kv2019i added bug Something isn't working as expected MTL Applies to Meteor Lake platform labels Dec 14, 2023
@kv2019i
Copy link
Collaborator Author

kv2019i commented Dec 14, 2023

@dabekjakub Can you check whether the calling sequence (i.e. the test) is correct? This seems to fail 100% and is causing "interesting" side-effects when failing (DSP panics as seen in #8621 ).

FYI @marc-hb @lyakh

@dabekjakub
Copy link
Member

Did this test pass when @lyakh submited it ? I am currently trying to setup unit testing for vmh. I will look at this one after I wrap up my tests.

@marc-hb
Copy link
Collaborator

marc-hb commented Dec 14, 2023

Did this test pass when @lyakh submited it ?

Yes on CAVS but not on MTL; never passed on the latter. See details in #8621

@lyakh
Copy link
Collaborator

lyakh commented Dec 15, 2023

Did this test pass when @lyakh submited it ?

Yes on CAVS but not on MTL; never passed on the latter. See details in #8621

@dabekjakub @marc-hb I'd say it depends on what "this test" is referring to. If it's referring to the complete boot-test, then yes, Marc's answer is correct. If however it's referring to the VMH test, then no, it never passed. The boot-test passed on cAVS because VMH is disabled there (IIRC, or at least the vmh test was never enabled there)

@lgirdwood
Copy link
Member

Ok, this is actually quite good (for ztest and we've caught an issue early) - it means the test results are being correctly captured. @kv2019i was this manual testing or automatic via CI ?

@marc-hb
Copy link
Collaborator

marc-hb commented Dec 18, 2023

Catching errors in firmware logs is still blocked because there are a few errors left in every run:

@marc-hb
Copy link
Collaborator

marc-hb commented Jan 8, 2024

Screenshots or console output

@kv2019i mtrace-reader.py is the only way to see this error log, correct?

https://github.com/thesofproject/sof/tree/main/tools/mtrace

@softwarecki softwarecki self-assigned this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected MTL Applies to Meteor Lake platform
Projects
None yet
Development

No branches or pull requests

6 participants