Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xtensa-build-zephyr.py: Re-add imx8ulp to -all #8584

Merged
merged 1 commit into from
Dec 14, 2023
Merged

xtensa-build-zephyr.py: Re-add imx8ulp to -all #8584

merged 1 commit into from
Dec 14, 2023

Conversation

dbaluta
Copy link
Collaborator

@dbaluta dbaluta commented Dec 6, 2023

This re-adds imx8ulp to --all platform list. This was removed in commit 7737efa ("xtensa-build-zephyr.py: remove imx8ulp from --all")

@dbaluta
xtensa-build-zephyr.py: Re-add imx8ulp to -all
1d5b8f4 
This re-adds imx8ulp to --all platform list. This was removed
in commit 7737efa ("xtensa-build-zephyr.py: remove imx8ulp from --all")

Signed-off-by: Daniel Baluta <[email protected]>
@dbaluta dbaluta requested a review from marc-hb as a code owner December 6, 2023 16:01
@dbaluta dbaluta changed the title xtensa-build-zephyr.py: Re-add imx8ulp to -all [DNM] xtensa-build-zephyr.py: Re-add imx8ulp to -all Dec 6, 2023
@dbaluta dbaluta marked this pull request as draft December 6, 2023 16:01
@dbaluta
Copy link
Collaborator Author

dbaluta commented Dec 6, 2023

We can merge this after #8582 gets in.

@marc-hb
Copy link
Collaborator

marc-hb commented Dec 8, 2023

This still won't build it in CI, you need to extend the list in .github/workflows/zephyr.yml. See commit a114c45

@dbaluta dbaluta marked this pull request as ready for review December 8, 2023 13:25
@dbaluta dbaluta changed the title [DNM] xtensa-build-zephyr.py: Re-add imx8ulp to -all xtensa-build-zephyr.py: Re-add imx8ulp to -all Dec 8, 2023
@dbaluta
Copy link
Collaborator Author

dbaluta commented Dec 8, 2023 •
edited
Loading

@marc-hb thanks for pointing out.

I've created this : #8596

... but I do have the feeling that I need to also update zephyr-sdk to include imx8ulp toolchain.

Indeed we need to upgrade zephyr sdk from zephyr-sdk-0.16.1 -> zephyr-sdk-0.16.4

Can someone at Intel help with this?

@marc-hb
Copy link
Collaborator

marc-hb commented Dec 8, 2023 •
edited
Loading

Indeed we need to upgrade zephyr sdk from zephyr-sdk-0.16.1 -> zephyr-sdk-0.16.4

Can someone at Intel help with this?

There should be only two numbers to bump:

Can you please try? (in a separate PR). It's a minor upgrade so there's a chance things will just work.

@marc-hb marc-hb mentioned this pull request Dec 8, 2023
Merged
@dbaluta
Copy link
Collaborator Author

dbaluta commented Dec 13, 2023

Can you please try? (in a separate PR). It's a minor upgrade so there's a chance things will just work.

Let's watch this and see what happens: #8618

@dbaluta dbaluta merged commit af3fa41 into thesofproject:main Dec 14, 2023
40 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuliana-prodan iuliana-prodan iuliana-prodan approved these changes

@kv2019i kv2019i kv2019i approved these changes

@marc-hb marc-hb Awaiting requested review from marc-hb

@LaurentiuM1234 LaurentiuM1234 Awaiting requested review from LaurentiuM1234

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbaluta @marc-hb @kv2019i @iuliana-prodan