audio: dai-zephyr: put no-data checks behind a build option #8649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put the data availability checks behind a build option (new option CONFIG_DAI_VERBOSE_GLITCH_WARNINGS). In normal conditions, the DAI copy should never be called in a condition when there is no data to be copied. The audio interface is running and needs a constant stream of audio samples, so there is no remedy for not having data. In practise, most of the DAIs have a small buffer and can survive transient small gaps in data flow. The existing code has warning level logs for this condition. This is very useful for debug, as many common problems in firmware (and DSP topologies) show up as delays observed in the DAI copy logic. For product use, printing the warnings may make the situation worse by increasing the DSP load at a time when it has just missed a deadline. To allow for both debug and to avoid these checks in product builds, move the related checks behind a separate build option. Signed-off-by: Kai Vehmanen <[email protected]>
Enable the DAI verbose glitch warnings in the debug builds. Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
lgirdwood
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by
#4672
and
#8621
... let's put the warnings behind a build option.