Fix universalis query not working in non-inject mode and misc fix #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the time when we query for universalis and delay the dto fire time to fix item id not handle issue
now it mainly blocking market history uploading (since we still does not fix the item id issue when uploading history)
|
|
Remove the MarketBoardRequestItemListingInfo and MarketBoardItemListingCount handling, seems MarketBoardItemListingCount not longer work for just sending all zero values
|
Still having some problems:
|
zhyupe
changed the base branch from
master
to
fix/market-on-network-only-mode
zhyupe
merged commit 710d549
into
thewakingsands:fix/market-on-network-only-mode
2 checks passed
|
Merged into a separate branch for further modification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.