Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOM Exception during large file upload #44

Open
slackwar opened this issue Jun 14, 2019 · 2 comments
Open

OOM Exception during large file upload #44

slackwar opened this issue Jun 14, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@slackwar
Copy link
Contributor

slackwar commented Jun 14, 2019

During large file(9+Gb) upload nexus3-cli crashes with OOM exception.

@bt-thiago
Copy link
Contributor

We fixed this in 7ace4b4 for downloads. It's the same fix for uploads (should be anyway).

@bt-thiago bt-thiago added the good first issue Good for newcomers label Jun 14, 2019
@bt-thiago
Copy link
Contributor

Looking at this again, the same fix is not enough for uploads because of this:

files = {'raw.asset1': open(src_file, 'rb').read()}

which loads the entire contents of the file to be uploaded in memory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants