Added couple of config parameters and fixed refresh_patterns #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memory_replacement_policy and cache_replacement_policy along with their validators. Signed-off-by: Babis Kaidos <[email protected]>
Signed-off-by: Babis Kaidos <[email protected]>
refresh patterns Signed-off-by: Babis Kaidos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the capability to configure 3 more parameters in squid.conf; cache_replacement_policy, memory_replacement_policy and cache peer. Also added refresh_patterns in the long template as the parameter setting code was missing.
I used validators but I noticed that you rely on checking with squid -k parse. Is this OK or would you like me to remove validators?