Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename refresh_token & fix ticket permissions #83

Merged
merged 8 commits into from
Oct 19, 2021
Merged

rename refresh_token & fix ticket permissions #83

merged 8 commits into from
Oct 19, 2021

Conversation

snicki13
Copy link
Member

Hotfixed:
Permissions on tickets: students may not edit, assign or delete a ticket.
Wider assignment field on tickets to support longer names.

Header: refresh_token -> refreshToken
The underscore is an illegal char in header names, which is why NGINX does not forward it by default.

@snicki13 snicki13 requested a review from mxsph October 19, 2021 09:57
@snicki13 snicki13 enabled auto-merge (squash) October 19, 2021 09:57
@mxsph mxsph changed the title Hotfix rename refresh_token & fix ticket permissions Oct 19, 2021
mxsph
mxsph requested changes Oct 19, 2021
View reviewed changes
Copy link
Member

@mxsph mxsph left a comment •
edited by snicki13
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, however there is still a problem with the ticket displays:

  • A lecturer should be able to use all actions for all tickets (currently he can only use them for his own tickets).
  • A student should be able to delete and edit his own ticket.

@snicki13 snicki13 requested a review from mxsph October 19, 2021 11:19
@snicki13
Copy link
Member Author

snicki13 commented Oct 19, 2021 •
edited by mxsph
Loading

Lecturers should not be able to edit tickets from students. They should be able to delete them.

Idea: add notes to tickets (#85)

@mxsph mxsph disabled auto-merge October 19, 2021 11:34
@mxsph mxsph added the bug Something isn't working label Oct 19, 2021
@mxsph mxsph merged commit 80c6295 into master Oct 19, 2021
@mxsph mxsph deleted the hotfix branch October 19, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxsph mxsph mxsph approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snicki13 @mxsph