Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support claude #33

Open
TwistingTwists opened this issue Mar 9, 2024 · 17 comments
Open

support claude #33

TwistingTwists opened this issue Mar 9, 2024 · 17 comments

Comments

@TwistingTwists
Copy link
Contributor

Hey,

I've been thinking about supporting Claude. I'll raise a PR once I am done.
@thmsmlr If you have suggestions around this, please let me know.

@knewter
Copy link

knewter commented Mar 10, 2024

i just read about claude being better at summarization, which is the task i'm playing with. Exciting to see if it performs better

@cigrainger
Copy link
Contributor

Yep +1 from me. If there's anything I can do to help, e.g. try out the PR, let me know.

@thmsmlr
Copy link
Owner

thmsmlr commented Mar 16, 2024

Yes, i'm in support. I don't think it should be too difficult, just a new adapter.

I have heard Claude really like XML style prompting. And while instructor_ex doesn't have much of an opinion on prompting style since it's mostly in control of the user, there are still a few prompts the instructor_ex does create and are hard coded.

As you play with it, let me know if this is a big issue. If so, we can create a separate PR to make internal prompt templating user configurable (like in the validation/re-asking code paths)

@TwistingTwists
Copy link
Contributor Author

I am in middle of some experiments with claude. Will revert back later this week to gather review and more opinions.

Warning: you may see some bad code. Please bear with me. :)

@thbar
Copy link
Collaborator

thbar commented Mar 17, 2024

@TwistingTwists paraphrasing Jacob Collier on musical creativity:

There is no such thing as "good code" or "bad code", it's just the code that feels right for you

Your contribution will be very appreciated no matter what (I will definitely enjoy using Claude), and someone can always improve it right after 😄

@knewter
Copy link

knewter commented Mar 18, 2024

i'd happily put some "bad code" through its paces :D

i'm rather excited to play with claude

@thbar
Copy link
Collaborator

thbar commented Mar 23, 2024

@TwistingTwists if you feel comfortable with that, I would love to see where you are on this (either with a draft PR or a fork of yours?).

Claude was in theory blocked in my country, but not if you go through their console/API mode, so happy to test things out!

(no pressure of course, but happy to try things out & report stuff)

@TwistingTwists
Copy link
Contributor Author

I'd push a branch out hopefully before next week starts. :)
Got distracted a little this week :)

@thbar
Copy link
Collaborator

thbar commented Mar 23, 2024

No problem really! Thanks!

@TwistingTwists
Copy link
Contributor Author

https://github.com/PrefectHQ/marvin/pull/865/files

This PR feels nice for injecting prompts etc stuff

@TwistingTwists
Copy link
Contributor Author

TwistingTwists commented Mar 25, 2024

#38 is wip.

@thbar : need a little help on json parsing in this PR.

@noozo
Copy link

noozo commented Apr 4, 2024

Would be nice to also be able to pass in the adapter with each call, since you might want to use the instructor across adapters in your code base, instead of being stuck with one. I could try to create a PR for that, if that's ok?

@noozo
Copy link

noozo commented Apr 4, 2024

Nevermind, just realized that you can pass it inside config (naming was a bit misleading for me).

@TwistingTwists
Copy link
Contributor Author

https://twitter.com/AnthropicAI/status/1775979799644934281

Anthropic going to support tool calling soon.

Do you still need to parse XML stuff ?

We can just rely on tool calls. :)

@TwistingTwists
Copy link
Contributor Author

tool calls - turns out that might not be the best at the moment.
see: https://twitter.com/jxnlco/status/1777350940502249532 for some practical experience on this.

@cigrainger
Copy link
Contributor

Hey! This is looking great -- anything I can do to help get it over the line? I'd love to use it.

@TwistingTwists
Copy link
Contributor Author

Will push it over this weekend. Will ping ya.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants