Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] ImageBoundingBox in BarcodeResult may lead to NRE #33

Open
thomasgalliker opened this issue Sep 28, 2024 · 0 comments
Open

[Refactoring] ImageBoundingBox in BarcodeResult may lead to NRE #33

thomasgalliker opened this issue Sep 28, 2024 · 0 comments
Assignees
@thomasgalliker
Labels
refactoring

Comments

@thomasgalliker
Copy link
Owner

Description

ImageBoundingBox in BarcodeResult is used in Equals and this could lead to a NullReferenceException. Avoid it and write a test for it.

References

CameraScanner.Maui/CameraScanner.Maui/BarcodeResult.cs

Line 34 in 8ed8c0e

if (this.RawValue == other.RawValue && this.ImageBoundingBox.IntersectsWith(other.ImageBoundingBox))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasgalliker thomasgalliker

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomasgalliker