Accept dynamic radius

[kmpoppe]

Couldn't get any dev environment to run in a short amount of time.
Would this work?

[thomersch]

I just allowed the test suite to run, let's see. Thanks for taking the time to add tests for this.

I must admit, I don't love the two vs. three parameter distinction. I think an extra get query parameter, e.g. around_radius, would be much cleaner.

[kmpoppe]

Updated to it's own parameter. The first run of the Workflow failed, but I couldn't really figure out what it was complaining about, it just threw some very inpolite emojis at me 😂

[thomersch]

I told the CI to be nice, but it doesn't seem to listen to me.

The project uses black to enforce consistent formatting and fails the workflow if the code style diverges from it.

Just a minor nitpick: Maybe it'd be nice to have an upper limit for the distance parameter to prevent enormous lookups. Something like 250 km perhaps?

[kmpoppe]

I shall take a look at the white spacing later, I might have mixed that up.

250k sounds good, will implement a fail condition.

[kmpoppe]

Well the last test failed because idiot me forgot a : 🤦, I've added an upper bound, and 0 not being a valid value, should've added < 0 as well, but would love to see if black is now happy.

[kmpoppe]

black still wants to reformat views.py, https://black.vercel.app/ suggest going from 521 to 568 lines, so it's not only my commit that's causing an issue... Do you want to redo views.py completely?

[kmpoppe]

I see, black's problem was about me, not about the code itself :-D
Thanks for making it cooperate :)

[thomersch]

I ran the formatter locally and it only reformatted some of the changed lines. That web tool probably didn't take into consideration that we allow 120 char line lengths.

Tests are passing, I validated the changes locally. Let's get this deployed! Thanks!

[kmpoppe]

Don't mention it, it's you allowing a change that was just a preparation for a long process ahead :-)

[kmpoppe]

Works pefectly!
https://osmcal.org/?around=54.6558,10.0255&around_radius=97 => zero results
https://osmcal.org/?around=54.6558,10.0255&around_radius=97.5 => 3 Stammtische in Lübeck, which are in 97.32 km distance!
Nice :)