Skip to content

Commit

Permalink
chore: fix signing for amino signers toolbox (#1193)
Browse files Browse the repository at this point in the history
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
towanTG and github-actions[bot] authored Feb 18, 2025
1 parent 95d6192 commit 79d10f0
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/odd-feet-fly.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@swapkit/toolbox-cosmos": patch
---

Fixes deposit signing for THORChain in keplr
30 changes: 27 additions & 3 deletions packages/toolboxes/cosmos/src/toolbox/thorchain.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ import {
getRPC,
} from "../util";

import { TxRaw } from "cosmjs-types/cosmos/tx/v1beta1/tx";
import { BaseCosmosToolbox } from "./BaseCosmosToolbox";

const secp256k1HdWalletFromMnemonic =
Expand Down Expand Up @@ -290,9 +291,32 @@ export const BaseThorchainToolbox = ({

const aminoMessage = buildAminoMsg({ assetValue, from, recipient, memo, chain });

const preparedMessage = isAminoSigner
? aminoMessage
: parseAminoMessageForDirectSigning(aminoMessage);
if (isAminoSigner) {
const msgSign = [convertToSignable(aminoMessage, chain)];

const { signatures, authInfoBytes } = await signingClient.sign(
from,
msgSign,
defaultFee,
memo,
);

const tx = TxRaw.encode({
signatures,
authInfoBytes,
bodyBytes: await buildEncodedTxBody({
chain,
msgs: [aminoMessage].map(parseAminoMessageForDirectSigning),
memo,
}),
}).finish();

const txResponse = await signingClient.broadcastTx(tx);

return txResponse.transactionHash;
}

const preparedMessage = parseAminoMessageForDirectSigning(aminoMessage);

const msgSign = convertToSignable(preparedMessage, chain);

Expand Down

0 comments on commit 79d10f0

Please sign in to comment.